Skip to content

FIX: Handle Row objects in executemany DAE fallback path (GH-629) #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gargsaumya merged 8 commits into from
Jun 11, 2026
+119 −0
Merged

FIX: Handle Row objects in executemany DAE fallback path (GH-629) #630

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
021fa7e
FIX: Handle Row objects in executemany DAE fallback path (GH-629)
gargsaumya Jun 10, 2026
ad9b4a8
Fix GH-629: Handle Row objects in executemany DAE fallback
gargsaumya Jun 10, 2026
27e1f68
Fix Black formatting - remove trailing blank line
gargsaumya Jun 10, 2026
e87021c
Simplify test docstring
gargsaumya Jun 10, 2026
a5ce8f0
Fix GH-629: unwrap Row params in execute() (root-cause fix)
gargsaumya Jun 10, 2026
7f5afd2
Add direct test for execute(sql, row) with Row params (GH-629)
gargsaumya Jun 11, 2026
13ec761
Merge remote-tracking branch 'origin/main' into saumya/gh-629
gargsaumya Jun 11, 2026
71faec7
Merge branch 'main' into saumya/gh-629
gargsaumya Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify test docstring
  • Loading branch information
@gargsaumya
gargsaumya committed Jun 10, 2026
commit e87021cec711c09bcfe4a09c8cd14f60d72f97e6
14 changes: 1 addition & 13 deletions tests/test_004_cursor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16597,19 +16597,7 @@ def test_executemany_multi_column_with_large_decimal(cursor, db_connection):


def test_executemany_row_objects_with_varchar_max_dae(cursor, db_connection):
Comment thread
gargsaumya marked this conversation as resolved.
"""Test executemany with Row objects from fetchmany() and VARCHAR(MAX) DAE fallback (GH-629).

When executemany() detects DAE parameters (large strings >4000 chars for VARCHAR(MAX)),
it falls back to row-by-row execution. This fallback must handle Row objects returned
by fetch APIs (fetchone/fetchmany/fetchall) by converting them to tuples before
passing to execute().

Without the GH-629 fix, this scenario raises:
TypeError: Unsupported parameter type: The driver cannot safely convert it to a SQL type.

This regression test ensures Row objects from fetch APIs can be passed directly to
executemany() even when DAE fallback is triggered.
"""
"""Test executemany with Row objects and VARCHAR(MAX) DAE fallback (GH-629)."""
try:
# Create source table with VARCHAR(MAX) column
cursor.execute("""
Expand Down
Loading