Fix a rare iced-x86 panic#921
Conversation
1695d73 to
3dbea36
Compare
|
As I'd mentioned on #697:
|
|
GPT-5.5 found the following issue: Medium — litebox_syscall_rewriter/src/lib.rs:843 |
3dbea36 to
e48dd5a
Compare
|
Thanks Weidong, that seems valid (I did not dive deeper into iced-x86 to confirm, since the change is a conservative fix). Pushed the fix. Also opened #927 to track the fact that we want to migrate away from iced-x86. |
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
#697 fixed a rare panic due to a boundary issue. Unfortunately, it was not fully sufficient, and there was still a (rarer) panic that could occur (e.g., https://github.com/microsoft/litebox/actions/runs/27575376051/job/81522248856). Basically, #697 handled "don't advance a chunk across 4GiB," but missed "don’t pass the overlap bytes across 4GiB either." This PR fixes it.