Python: Remove duplicate pop in InMemoryCacheProvider.remove#5795
Merged
eavanvalkenburg merged 1 commit intoMay 19, 2026
Merged
Conversation
The second self._cache.pop(key, None) call is a guaranteed no-op: the first pop has already removed the key (or returned None), and there is no await between the two statements that could allow another coroutine to re-add it. Removing the dead line clarifies intent without changing behavior.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a redundant second pop call in InMemoryCacheProvider.remove within the Purview Python package. The change eliminates dead code while preserving identical runtime behavior and keeping the public API unchanged.
Changes:
- Remove a duplicate
self._cache.pop(key, None)inInMemoryCacheProvider.remove, leaving the size-accounting logic intact.
Contributor
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||
eavanvalkenburg
approved these changes
May 18, 2026
SergeyMenshykh
approved these changes
May 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
removemethod inInMemoryCacheProvider(purview package) contains a duplicateself._cache.pop(key, None)call. The second call is dead code: the first
pophas already either removed the key or returnedNone, and thereis no
awaitbetween the two statements that could allow another coroutine to re-add the key. The redundant line ismisleading to readers (suggests it's guarding against something it isn't) and adds noise to the diff history.
Description
Removes the second
self._cache.pop(key, None)call inInMemoryCacheProvider.remove.Behavior is identical before and after for every input:
popremoves it and decrements_current_size_bytes. The secondpop(nowremoved) found nothing.
popcalls were no-ops.No public API change. No test changes required — existing
test_cache.pytests continue to pass.Contribution Checklist
Guidelines