Skip to content

.NET: Re-enable AzureAI.Persistent packaging and integration tests#4865

Merged
rogerbarreto merged 1 commit into
microsoft:mainfrom
rogerbarreto:issues/persistent-beta-10-update
Mar 24, 2026
Merged

.NET: Re-enable AzureAI.Persistent packaging and integration tests#4865
rogerbarreto merged 1 commit into
microsoft:mainfrom
rogerbarreto:issues/persistent-beta-10-update

Conversation

@rogerbarreto

Copy link
Copy Markdown
Member

Motivation and Context

Azure.AI.Agents.Persistent 1.2.0-beta.10 now targets Microsoft.Extensions.AI 10.4.0+, resolving the compatibility issue (McpServerToolApprovalResponseContentToolApprovalResponseContent rename) that required disabling this package from NuGet shipping and its integration tests.

Closes #4769

Description

  • Removed <IsPackable>false</IsPackable> from Microsoft.Agents.AI.AzureAI.Persistent.csproj to re-enable NuGet packaging
  • Re-enabled all 6 integration test classes by changing [Trait("Category", "IntegrationDisabled")][Trait("Category", "Integration")] and removing the associated disable comments
  • Removed the outdated compatibility warning section from README.md

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

…icrosoft#4769)

Azure.AI.Agents.Persistent 1.2.0-beta.10 now targets ME.AI 10.4.0+,
resolving the compatibility issue that required disabling this package.

- Remove IsPackable=false from the csproj
- Re-enable all 6 integration test classes (IntegrationDisabled → Integration)
- Remove outdated compatibility warning from README.md

Co-authored-by: Copilot <[email protected]>
Copilot AI review requested due to automatic review settings March 23, 2026 18:46
@markwallace-microsoft markwallace-microsoft added documentation Improvements or additions to documentation .NET Issues related to the .NET codebase labels Mar 23, 2026
@rogerbarreto rogerbarreto self-assigned this Mar 23, 2026
@rogerbarreto rogerbarreto moved this to In Review in Agent Framework Mar 23, 2026
@rogerbarreto rogerbarreto enabled auto-merge March 23, 2026 18:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Re-enables packaging and CI integration testing for the Microsoft.Agents.AI.AzureAI.Persistent .NET integration layer now that Azure.AI.Agents.Persistent has updated compatibility with Microsoft.Extensions.AI 10.4.0+.

Changes:

  • Re-enabled NuGet packaging for Microsoft.Agents.AI.AzureAI.Persistent by removing the IsPackable=false override.
  • Re-enabled Azure AI Persistent integration test classes by switching their test category trait back to "Integration".
  • Removed the now-obsolete compatibility warning block from the package README.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
dotnet/src/Microsoft.Agents.AI.AzureAI.Persistent/Microsoft.Agents.AI.AzureAI.Persistent.csproj Allows the project to be packable again for NuGet shipping.
dotnet/src/Microsoft.Agents.AI.AzureAI.Persistent/README.md Removes outdated compatibility limitation content.
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsPersistentCreateTests.cs Re-enables integration test class via trait change.
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsPersistentRunTests.cs Re-enables integration test class via trait change.
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsPersistentRunStreamingTests.cs Re-enables integration test class via trait change.
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsPersistentStructuredOutputRunTests.cs Re-enables integration test class via trait change (but current logic still skips tests).
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsChatClientAgentRunTests.cs Re-enables integration test class via trait change.
dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsChatClientAgentRunStreamingTests.cs Re-enables integration test class via trait change.
Comments suppressed due to low confidence (1)

dotnet/tests/AzureAIAgentsPersistent.IntegrationTests/AzureAIAgentsPersistentStructuredOutputRunTests.cs:12

  • SkipReason is a non-null const string, so Assert.SkipWhen(SkipReason is not null, ...) will always evaluate true and these structured-output integration tests will always be skipped even after re-enabling the [Trait("Category", "Integration")] category. If these tests are meant to run again, make the skip conditional (e.g., based on an env var/CI detection) or remove the overrides and let the base tests execute; if they must stay disabled, consider marking them with an explicit xUnit Skip attribute or reverting this class back to an IntegrationDisabled category to avoid giving a false sense of coverage.
[Trait("Category", "Integration")]
public class AzureAIAgentsPersistentStructuredOutputRunTests() : StructuredOutputRunTests<AzureAIAgentsPersistentFixture>(() => new())
{
    private const string SkipReason = "Fails intermittently on the build agent/CI";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation .NET Issues related to the .NET codebase

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

.NET: Re-enable AzureAIAgentsPersistent integration tests after Azure.AI.Agents.Persistent targets ME.AI 10.4.0+

5 participants