Python: Refactor RequestInfoExecutor#1403
Merged
TaoChenOSU merged 5 commits intoOct 13, 2025
Merged
Conversation
TaoChenOSU
added
python
github-actions
Bot
changed the title
RequestInfoExecutorRequestInfoExecutor
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the RequestInfoExecutor by introducing a structured PendingRequestSnapshot type to replace dictionary-based data structures and extracts checkpoint summary functionality into a separate module.
- Introduces
PendingRequestSnapshotdataclass for better type safety in request tracking - Moves
WorkflowCheckpointSummaryand related functions to a new_checkpoint_summary.pymodule - Updates workflow sample files to use the new
get_checkpoint_summaryfunction instead of static methods
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
python/packages/core/agent_framework/_workflows/_request_info_executor.py |
Major refactor replacing dictionary-based pending requests with typed PendingRequestSnapshot, moving checkpoint functionality |
python/packages/core/agent_framework/_workflows/_checkpoint_summary.py |
New module containing extracted checkpoint summary functionality |
python/packages/core/agent_framework/_workflows/__init__.py |
Exports new types and functions from the refactored modules |
| Sample files | Updated to use new get_checkpoint_summary function |
| Test files | Updated to use new data structures and removed outdated tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Python Test Coverage Report •
Python Unit Test Overview
|
|||||||||||||||||||||||||||||||||||||||||||||
lokitoth
reviewed
Oct 13, 2025
lokitoth
reviewed
Oct 13, 2025
lokitoth
reviewed
Oct 13, 2025
ekzhu
reviewed
Oct 13, 2025
ekzhu
approved these changes
Oct 13, 2025
dmytrostruk
approved these changes
Oct 13, 2025
ReubenBond
pushed a commit
to ReubenBond/agent-framework
that referenced
this pull request
Oct 28, 2025
* Refactor RequestInfoExecutor * Update AI script * Fix formatting * Address comments * fix unit test
arisng
pushed a commit
to arisng/agent-framework
that referenced
this pull request
Feb 2, 2026
* Refactor RequestInfoExecutor * Update AI script * Fix formatting * Address comments * fix unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
RequestInfoExecutorhas too many data structures that are dictionary based without clear definitions of the keys and values. TheRequestInfoExecutormodule also contains classes that can be put into their own modules.This PR aims to refactor the
RequestInfoExecutorclass and the module that contains it. This will slim down the module and make theRequestInfoExecutormore maintainable such that we can further build on top of it.Description
PendingRequestSnapshottype to replace the original dictionary-based data structure. This also removes some unused propterties.WorkflowCheckpointSummaryand related methods to their own module_checkpoint_summary.py.Contribution Checklist