Skip to content

Fix ghost errors resulting from out-of-order type checking #58337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 9 commits into from
Apr 29, 2024
Merged

Fix ghost errors resulting from out-of-order type checking #58337

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1b97bf3
Fix for "inverted" scenarios that cause circularities
ahejlsberg Apr 26, 2024
a555303
Accept new baselines
ahejlsberg Apr 26, 2024
29c2575
Always keep the first resolvedReturnType
ahejlsberg Apr 27, 2024
ff7ae6d
Always keep first resolved value in push/popTypeResolution guarded logic
ahejlsberg Apr 27, 2024
d32444c
Accept new baselines
ahejlsberg Apr 27, 2024
abf4012
Add tests
ahejlsberg Apr 27, 2024
9171b4d
Properly restore resolutionStart in variance computation
ahejlsberg Apr 28, 2024
15399e9
Add test
ahejlsberg Apr 28, 2024
e5e1a0d
Accept new baselines
ahejlsberg Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Accept new baselines
  • Loading branch information
@ahejlsberg
ahejlsberg committed Apr 26, 2024
commit a555303fd4e8ea66b5f2eca0498e7e76188d6ff5
8 changes: 7 additions & 1 deletion tests/baselines/reference/circularReferenceInReturnType.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
circularReferenceInReturnType.ts(3,7): error TS7022: 'res1' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
circularReferenceInReturnType.ts(3,18): error TS7024: Function implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
circularReferenceInReturnType.ts(9,7): error TS7022: 'res3' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
circularReferenceInReturnType.ts(9,20): error TS7024: Function implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.


==== circularReferenceInReturnType.ts (2 errors) ====
==== circularReferenceInReturnType.ts (4 errors) ====
// inference fails for res1 and res2, but ideally should not
declare function fn1<T>(cb: () => T): string;
const res1 = fn1(() => res1);
~~~~
!!! error TS7022: 'res1' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
~~~~~~~~~~
!!! error TS7024: Function implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.

declare function fn2<T>(): (cb: () => any) => (a: T) => void;
const res2 = fn2()(() => res2);
Expand All @@ -16,4 +20,6 @@ circularReferenceInReturnType.ts(9,7): error TS7022: 'res3' implicitly has type
const res3 = fn3()(() => res3);
~~~~
!!! error TS7022: 'res3' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
~~~~~~~~~~
!!! error TS7024: Function implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.