Remove createUnderscoreEscapedMultiMap#53029
Merged
Merged
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
Member
Author
|
That being said, I'm not sure why we have a specific type for underscore escaped maps either; was that just an artifact of the pre-ES maps change? |
Member
|
Probably, since |
Member
|
@typescript-bot perf test faster |
Contributor
|
Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 2adfe45. You can monitor the build here. |
Member
Author
|
Yeah. I'll probably tack that removal on here, then, if it compiles that is. |
Member
Author
|
Ugh, those types are public, of course. |
Member
Author
|
I'll send a different PR for that cleanup so this one doesn't have a public API change. |
DanielRosenwasser
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createMultiMapworks fine with__String, so I think we can remove this.