Speed up debug attach by setting outFiles#52584
Merged
Merged
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
commented
Feb 3, 2023
| "NODE_ENV": "testing" | ||
| }, | ||
| "outFiles": [ | ||
| "${workspaceFolder}/built/**/*.js", |
Member
Author
There was a problem hiding this comment.
For future proofing maybe {js,mjs,cjs} though...
Member
There was a problem hiding this comment.
If anyone seconds it:
Suggested change
| "${workspaceFolder}/built/**/*.js", | |
| "${workspaceFolder}/built/**/*.{js,mjs,cjs}", |
Member
Author
There was a problem hiding this comment.
Oops, this syntax doesn't actually work in this position. I guess these globs are different?
DanielRosenwasser
approved these changes
Feb 3, 2023
Member
|
Lgtm |
Co-authored-by: Daniel Rosenwasser <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the startup time of the debugger. This is a template, so everyone will have to manually copy this if they want it.
(I had this locally after it was suggested by @connor4312 and then proceeded to entirely forget to send this.)