Skip to content

Add an action to update baselines/fix lints#39898

Merged
DanielRosenwasser merged 2 commits into
masterfrom
updateBaselinesFixLintsAction
Nov 21, 2020
Merged

Add an action to update baselines/fix lints#39898
DanielRosenwasser merged 2 commits into
masterfrom
updateBaselinesFixLintsAction

Conversation

@DanielRosenwasser

@DanielRosenwasser DanielRosenwasser commented Aug 4, 2020

Copy link
Copy Markdown
Member

Fixes #37765

The workflow will more or less look like this

image

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Aug 4, 2020

- name: Configure Git, Run Tests, Update Baselines, Apply Fixes
run: |
git config user.email "[email protected]"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, blame it on Ryan!

@DanielRosenwasser DanielRosenwasser Aug 4, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So all of our actions do this. Two things:

  1. Do we have a Microsoft account we can use @RyanCavanaugh?
  2. Is there a way to use the person who triggered the action's email?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. [email protected]
  2. I believe ${{github.actor}}@users.noreply.github.com should do the trick

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe ${{github.actor}}@users.noreply.github.com should do the trick

I think if your account isn't old enough, you have to use something like a special user ID email.

https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address#about-commit-email-addresses

If you created your GitHub account after July 18, 2017, your GitHub-provided no-reply email address is a seven-digit ID number and your username in the form of [email protected]. If you created your GitHub account prior to July 18, 2017, your GitHub-provided no-reply email address is your username in the form of [email protected]. You can get an ID-based GitHub-provided no-reply email address by selecting (or deselecting and reselecting) Keep my email address private in your email settings.

@sheetalkamat

Copy link
Copy Markdown
Member

I am assuming we can do this on PR or a branch and would make life so much easier to just accept baselines or fix lint errors rather than having to do them locally after finding out from bigger run

@weswigham

Copy link
Copy Markdown
Member

I don't think the action will work on PRs from forks in this form.

@sheetalkamat

Copy link
Copy Markdown
Member

May be make it bot work then ?

@DanielRosenwasser

Copy link
Copy Markdown
Member Author

I think this is useful enough for team PRs.

@DanielRosenwasser DanielRosenwasser merged commit f4157b4 into master Nov 21, 2020
@DanielRosenwasser DanielRosenwasser deleted the updateBaselinesFixLintsAction branch November 21, 2020 00:05
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

typescript-bot: baseline-accept and fix-lints

7 participants