Skip to content

Dont count duplicated errors in case-insensitive duped files in rwc #24383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weswigham merged 1 commit into from
May 24, 2018
Merged

Dont count duplicated errors in case-insensitive duped files in rwc #24383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/harness/harness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,7 +1469,14 @@ namespace Harness {

// Verify we didn't miss any errors in this file
assert.equal(markedErrorCount, fileErrors.length, "count of errors in " + inputFile.unitName);
const isDupe = dupeCase.has(sanitizeTestFilePath(inputFile.unitName));
yield [checkDuplicatedFileName(inputFile.unitName, dupeCase), outputLines, errorsReported];
if (isDupe && !(options && options.caseSensitive)) {
// Case-duplicated files on a case-insensitive build will have errors reported in both the dupe and the original
// thanks to the canse-insensitive path comparison on the error file path - We only want to count those errors once
// for the assert below, so we subtract them here.
totalErrorsReportedInNonLibraryFiles -= errorsReported;
}
outputLines = "";
errorsReported = 0;
}
Expand Down