Initial commit for dashboard embed SDK support#29
Closed
wenwa wants to merge 2 commits intomicrosoft:masterfrom
Closed
Initial commit for dashboard embed SDK support#29wenwa wants to merge 2 commits intomicrosoft:masterfrom
wenwa wants to merge 2 commits intomicrosoft:masterfrom
Conversation
|
Hi @wenwa, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Contributor
|
I'm not sure what the goal is for this but I would have expected this to be requested to merge with dev instead of master. This looks like it is using the legacy load and other methods. It's much more scalable to build this using the newer communication style seen on dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.