Merged
Conversation
suri-kumkaran
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a lightweight RFC (Request for Comments) process for DiskANN using a PR-based lifecycle, with RFC documents stored under rfcs/ and named using the zero-padded PR number convention.
Changes:
- Add
rfcs/README.mddocumenting when RFCs are recommended, the PR-based lifecycle, and submission steps. - Add
rfcs/00000-template.mdas a standardized RFC authoring template.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rfcs/README.md | Documents the RFC process, lifecycle, and naming/labeling conventions. |
| rfcs/00000-template.md | Provides a standard RFC template with sections for motivation, proposal, trade-offs, benchmarks, and references. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
=======================================
Coverage 89.47% 89.47%
=======================================
Files 432 432
Lines 79433 79433
=======================================
Hits 71071 71071
Misses 8362 8362
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
hildebrandmw
approved these changes
Feb 27, 2026
Contributor
hildebrandmw
left a comment
hildebrandmw
left a comment
There was a problem hiding this comment.
Thanks @suri-kumkaran !
harsha-simhadri
approved these changes
Feb 27, 2026
Merged
hildebrandmw
added a commit
that referenced
this pull request
Mar 4, 2026
## What's Changed * Expand BetaFilter for External SearchStrategy Implementations by @hailangx in #793 * Enable Miri tests in CI with non-blocking execution by @Copilot in #697 * Increase unit test coverage for diskann-disk crate by @Copilot in #761 * Add code review instructions for license headers by @harsha-simhadri in #801 * Consolidate `load_bin` somewhat by @hildebrandmw in #792 * Add RFC process by @suri-kumkaran in #804 * Fix variance issues with `Mat` and `MatMut`. by @hildebrandmw in #806 * [Bugfix] NeighborPriorityQueue panics, when it is at capacity and NaN distance is inserted by @arrayka in #796 * Enable `cache_only` mode for the BF-Tree cache by @hildebrandmw in #810 * Enable customization of Tokio runtimes in `diskann-benchmark-core` by @hildebrandmw in #809 ## New Contributors * @hailangx made their first contribution in #793 **Full Changelog**: v0.47.0...v0.48.0 Co-authored-by: Mark Hildebrand <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a lightweight RFC (Request for Comments) process for DiskANN, providing a structured way to propose and discuss substantial design changes.
What's Included
rfcs/README.md— Defines when to write an RFC, the lifecycle, and how to submit onerfcs/00000-template.md— Standard template for new RFCsKey Design Decisions
NNNNN-short-title.mdusing the 5-digit zero-padded PR number (following the convention used by the Rust project). Authors start with00000-short-title.mdand rename after PR creation.RFClabel: RFC pull requests are tagged with anRFClabel for discoverability.Scope
An RFC is recommended for cross-cutting, architecturally significant, or API-affecting changes. It is not required for single-crate additions, bug fixes, internal refactors, or documentation improvements.