Skip to content

esp32/machine_pin: Make all pins on ESP32-P4 output capable.#18983

Open
sfe-SparkFro wants to merge 1 commit intomicropython:masterfrom
sparkfun:fix_esp32p4_pin54_input_only
Open

esp32/machine_pin: Make all pins on ESP32-P4 output capable.#18983
sfe-SparkFro wants to merge 1 commit intomicropython:masterfrom
sparkfun:fix_esp32p4_pin54_input_only

Conversation

@sfe-SparkFro
Copy link
Contributor

Summary

All GPIO pins on the ESP32-P4 are output capable, so there is no need to define GPIO_FIRST_NON_OUTPUT.

Also fixes #18982, since GPIO_FIRST_NON_OUTPUT was incorrectly set to 54, preventing that pin from being configured as an output.

Testing

Tested on an ESP32-P4 board. Before this change, pin 54 could not be configured as an output. After this change, it can. Tested with an LED to verify it toggles correctly.

Generative AI

I did not use generative AI tools when creating this PR.

@github-actions
Copy link

Code size report:

Reference:  tools/ci.sh: Increase qemu_arm test run timeout. [5c00edc]
Comparison: esp32/machine_pin: Make all pins on ESP32-P4 output capable. [merge of fb21817]
  mpy-cross:    +0 +0.000% 
   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
      esp32:    +0 +0.000% ESP32_GENERIC
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

esp32/machine_pin: ESP32-P4 pin 54 can't be set to output

1 participant