esp32/machine_pin: Make all pins on ESP32-P4 output capable.#18983
Open
sfe-SparkFro wants to merge 1 commit intomicropython:masterfrom
Open
esp32/machine_pin: Make all pins on ESP32-P4 output capable.#18983sfe-SparkFro wants to merge 1 commit intomicropython:masterfrom
sfe-SparkFro wants to merge 1 commit intomicropython:masterfrom
Conversation
Fixes micropython#18982. Signed-off-by: Dryw Wade <[email protected]>
|
Code size report: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All GPIO pins on the ESP32-P4 are output capable, so there is no need to define
GPIO_FIRST_NON_OUTPUT.Also fixes #18982, since
GPIO_FIRST_NON_OUTPUTwas incorrectly set to54, preventing that pin from being configured as an output.Testing
Tested on an ESP32-P4 board. Before this change, pin 54 could not be configured as an output. After this change, it can. Tested with an LED to verify it toggles correctly.
Generative AI
I did not use generative AI tools when creating this PR.