Signature help: restructure async work#1198
Merged
microbit-matt-hillsdon merged 2 commits intomainfrom Dec 9, 2024
Merged
Conversation
sendRequest isn't an async function as it can synchronously throw errors so we need something to prevent reentrant updates in the error case. Otherwise though we don't needed it if we move more work into the state.
|
Preview build will be at |
I'm not sure this is necessary but it feels obviously correct / straightforward which is a win in this code.
| }, | ||
| }); | ||
|
|
||
| const triggerSignatureHelpRequest = async ( |
Collaborator
Author
There was a problem hiding this comment.
I think I found this hard to pick up again & understand because this function is called from two very different contexts: a CM command (where it's totally fine / expected to view.dispatch) and and the ViewPlugin update call. Doubtless my doing!
microbit-robert
approved these changes
Dec 9, 2024
Collaborator
microbit-robert
left a comment
microbit-robert
left a comment
There was a problem hiding this comment.
I think this looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendRequest isn't an async function as it can synchronously throw errors so we need something to prevent reentrant updates in the error case.
Otherwise though we don't needed it if we move more work into the state.
Alternative take on #1196 that's a bit of a bigger change but perhaps a better split of work between state/view plugin.