Skip to content

[master < T0873-MG] Forbid two replicas to point to the same ip port#406

Merged
kostasrim merged 16 commits intomasterfrom
T0873-MG-forbid-two-replicas-to-point-to-the-same-ip-port
Jun 20, 2022
Merged

[master < T0873-MG] Forbid two replicas to point to the same ip port#406
kostasrim merged 16 commits intomasterfrom
T0873-MG-forbid-two-replicas-to-point-to-the-same-ip-port

Conversation

@42jeremy
Copy link
Contributor

@42jeremy 42jeremy commented Jun 10, 2022

  • Check, and update documentation if necessary: nothing to update
  • Update changelog

Docs PR

@42jeremy 42jeremy changed the title [MG < T0873] forbid two replicas to point to the same ip port [master < T0873-MG] Forbid two replicas to point to the same ip port Jun 10, 2022
@42jeremy 42jeremy self-assigned this Jun 10, 2022
@42jeremy 42jeremy requested a review from gitbuda June 10, 2022 10:39
@42jeremy
Copy link
Contributor Author

Given that the issue is already reproducible with UT, do we also want integration tests? (I have some tests ready for that, see the commits I reverted).

@42jeremy 42jeremy marked this pull request as ready for review June 10, 2022 10:41
@42jeremy 42jeremy requested review from jbajic and spacejam June 10, 2022 10:47
@42jeremy 42jeremy added the bug bug label Jun 10, 2022
@42jeremy 42jeremy requested a review from kostasrim June 15, 2022 06:07
Copy link
Contributor

@kostasrim kostasrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small changes!

@42jeremy 42jeremy requested a review from kostasrim June 15, 2022 11:19
@kostasrim kostasrim merged commit 589e0e0 into master Jun 20, 2022
@kostasrim kostasrim deleted the T0873-MG-forbid-two-replicas-to-point-to-the-same-ip-port branch June 20, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants