Skip to content

Bugfix: Edge index RemoveObsoleteEntries breaks MVCC isolation#3383

Merged
andrejtonev merged 3 commits intomasterfrom
edge_index_obsolete_check_fix
Oct 29, 2025
Merged

Bugfix: Edge index RemoveObsoleteEntries breaks MVCC isolation#3383
andrejtonev merged 3 commits intomasterfrom
edge_index_obsolete_check_fix

Conversation

@andrejtonev
Copy link
Contributor

@andrejtonev andrejtonev commented Oct 28, 2025 •
edited
Loading

GC runs would cause edge indices to remove edges that were deleted but might still be accessible from an older transaction.
Bug introduced in v2.21

@andrejtonev andrejtonev added this to the mg-v3.7.0 milestone Oct 28, 2025
@andrejtonev andrejtonev self-assigned this Oct 28, 2025
@andrejtonev andrejtonev added bug bug Docs - changelog only Docs - changelog only CI -build=coverage -test=core Run coverage build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=stress Run release build and stress tests on push CI -build=coverage -test=clang_tidy labels Oct 28, 2025
@andrejtonev
Copy link
Contributor Author

andrejtonev commented Oct 28, 2025 •
edited
Loading

Git commit description, explain the changes you made here

Leave above in PR description, copy the below into a comment

Tracking

  • [Link to Epic/Issue]

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Bugfix: Edge indices skip deleted edges regardless of transaction start time and isolation level. Users that use edge indices will now see the correct result based on their transaction and isolation. #3383
  • [ Documentation PR link memgraph/documentation#XXXX ]
    • Is back linked to this development PR

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 29, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.5% Duplication on New Code

See analysis details on SonarQube Cloud

@andrejtonev andrejtonev added this pull request to the merge queue Oct 29, 2025
Merged via the queue into master with commit 5c09b63 Oct 29, 2025
33 checks passed
@andrejtonev andrejtonev deleted the edge_index_obsolete_check_fix branch October 29, 2025 12:29
@gitbuda gitbuda mentioned this pull request Nov 10, 2025
Merged
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ignition Ignition Ignition approved these changes

@imilinovic imilinovic imilinovic approved these changes

Assignees

@andrejtonev andrejtonev

Labels

bug bug CI -build=coverage -test=clang_tidy CI -build=coverage -test=core Run coverage build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=stress Run release build and stress tests on push Docs - changelog only Docs - changelog only

Projects

None yet

Milestone

mg-v3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrejtonev @Ignition @imilinovic