[master < T0802-MG] Make temporal types now functions use the query context timestamp#333
Merged
antonio2368 merged 5 commits intomasterfrom Feb 4, 2022
Conversation
kostasrim
requested review from
antaljanosbenjamin,
antonio2368,
gitbuda and
jbajic
as code owners
kostasrim
force-pushed
the
T0802-MG-make-temporal-types-now-functions-use-the-query-context-timestamp
branch
from
ee712c4 to
086f6aa
Compare
jbajic
approved these changes
Feb 2, 2022
antaljanosbenjamin
suggested changes
Feb 2, 2022
Comment on lines
-109
to
+89
| const auto utc_today = GetUtcFromSystemClockOrThrow(); | ||
| return LocalDateTime({TMYearToUtcYear(utc_today.tm_year), TMMonthToUtcMonth(utc_today.tm_mon), utc_today.tm_mday}, | ||
| {utc_today.tm_hour, utc_today.tm_min, utc_today.tm_sec}); | ||
| namespace chrono = std::chrono; | ||
| auto ts = chrono::time_point_cast<chrono::microseconds>(chrono::system_clock::now()); | ||
| return LocalDateTime(ts.time_since_epoch().count()); |
Contributor
There was a problem hiding this comment.
Will this return UTC time? I guess no, but you opted from chrono to be consistent with the timestamp thingy. And that is fine, however I think these function should be renamed, because in this case their name is misleading.
Contributor
Author
There was a problem hiding this comment.
You are right and I will very happily rename it!
antonio2368
approved these changes
Feb 3, 2022
kostasrim
force-pushed
the
T0802-MG-make-temporal-types-now-functions-use-the-query-context-timestamp
branch
from
086f6aa to
15acbb1
Compare
antaljanosbenjamin
approved these changes
Feb 3, 2022
Contributor
Author
|
Don't merge. Need to update the change log and rebase. |
…-use-the-query-context-timestamp
Contributor
|
Can this be merged now? |
Contributor
Author
antonio2368
deleted the
T0802-MG-make-temporal-types-now-functions-use-the-query-context-timestamp
branch
as51340
pushed a commit
that referenced
this pull request
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[master < Epic] PR
[master < Task] PR