Skip to content

Function calls made cheaper#2640

Merged
Ignition merged 1 commit intomasterfrom
2025_01_28_query_module_perf
Jan 29, 2025
Merged

Function calls made cheaper#2640
Ignition merged 1 commit intomasterfrom
2025_01_28_query_module_perf

Conversation

@Ignition
Copy link
Contributor

@Ignition Ignition commented Jan 28, 2025

  • Avoid default ctr of TypedValue, prefer move ctr
  • Make TypedValue dtr do only essential work
  • Optimise TypedValue assignment when memory and type are same
  • Only construct + destroy the arguments that are needed

@Ignition Ignition added this to the mg-v3.1.0 milestone Jan 28, 2025
@Ignition Ignition self-assigned this Jan 28, 2025
@Ignition
Copy link
Contributor Author

Ignition commented Jan 28, 2025 •
edited
Loading

Tracking

  • [Link to Epic/Issue]

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Performance improvement around calling of query modules, less work is performed setting up and moving around values. #2640
  • [ Documentation PR link memgraph/documentation#XXXX ]
    • Is back linked to this development PR
  • [ Tag someone from docs team ]

@Ignition Ignition added CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=benchmark Run release build and benchmark on push CI -build=release -test=query_modules Run release build and query modules tests on push labels Jan 28, 2025
@Ignition Ignition force-pushed the 2025_01_28_query_module_perf branch from 27416ef to d05b626 Compare January 28, 2025 15:18
@Ignition
Make function calls made cheaper
9d11e78 
- Avoid default ctr of TypedValue, prefer move ctr
- Make TypedValue dtr do only essential work
- Optimise TypedValue assignment when memory and type are same
- Only construct + destroy the arguments that are needed
@Ignition Ignition force-pushed the 2025_01_28_query_module_perf branch from d05b626 to 9d11e78 Compare January 28, 2025 15:45
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 28, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ignition Ignition marked this pull request as ready for review January 29, 2025 10:33
@Ignition Ignition enabled auto-merge January 29, 2025 13:23
@as51340 as51340 self-requested a review January 29, 2025 13:53
as51340
as51340 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ignition Ignition added this pull request to the merge queue Jan 29, 2025
Merged via the queue into master with commit 24ba5a8 Jan 29, 2025
15 checks passed
@Ignition Ignition deleted the 2025_01_28_query_module_perf branch January 29, 2025 15:29
@gitbuda gitbuda mentioned this pull request Mar 11, 2025
Merged
49 tasks
as51340 pushed a commit that referenced this pull request Oct 24, 2025
@Ignition
Function calls made cheaper (#2640)
3a4e693 
- Avoid default ctr of TypedValue, prefer move ctr
- Make TypedValue dtr do only essential work
- Optimise TypedValue assignment when memory and type are same
- Only construct + destroy the arguments that are needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@as51340 as51340 as51340 approved these changes

@Josipmrden Josipmrden Awaiting requested review from Josipmrden

@andrejtonev andrejtonev Awaiting requested review from andrejtonev

@imilinovic imilinovic Awaiting requested review from imilinovic

Assignees

@Ignition Ignition

Labels

Capability - speed or performance CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=benchmark Run release build and benchmark on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=query_modules Run release build and query modules tests on push Docs - changelog only Docs - changelog only

Projects

None yet

Milestone

mg-v3.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Ignition @as51340