Avoid reloading dgl and numpy modules; remove deprecated python C-API function#2638
Merged
Avoid reloading dgl and numpy modules; remove deprecated python C-API function#2638
Conversation
DavIvek
added
bug
Contributor
Author
Tracking
Standard development
CI Testing Labels
Documentation checklist
|
DavIvek
changed the title
DavIvek
changed the title
as51340
requested changes
Jan 28, 2025
imilinovic
approved these changes
Jan 28, 2025
Contributor
Author
|
This PR must be merged before memgraph/mage#535 to ensure all modules work as expected. |
19 tasks
as51340
approved these changes
Jan 29, 2025
DavIvek
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
DavIvek
added
the
CI -build=debug -test=core
|
49 tasks
as51340
pushed a commit
that referenced
this pull request
Oct 24, 2025
… function (#2638) Some Python modules should not be loaded more than once. This PR adds `numpy` and `dgl` to that list to avoid potential issues. This is mandatory to use latest versions of mentioned packages. Additionally, a deprecated call to `PyEval_InitThreads` has been removed, as it no longer has any effect starting from [Python 3.9](https://docs.python.org/3/whatsnew/3.9.html).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Python modules should not be loaded more than once. This PR adds
numpyanddglto that list to avoid potential issues. This is mandatory to use latest versions of mentioned packages.Additionally, a deprecated call to
PyEval_InitThreadshas been removed, as it no longer has any effect starting from Python 3.9.