Bugfix: Recursive allocations inside query memory tracker#2634
Merged
andrejtonev merged 2 commits intomasterfrom Jan 24, 2025
Merged
Bugfix: Recursive allocations inside query memory tracker#2634andrejtonev merged 2 commits intomasterfrom
andrejtonev merged 2 commits intomasterfrom
Conversation
Contributor
Author
Tracking
Standard development
CI Testing Labels
Documentation checklist
|
andrejtonev
added
bug
andrejtonev
force-pushed
the
mem_tracker_deadlock_fix
branch
from
5fb07b5 to
b336c6f
Compare
Ignition
approved these changes
Jan 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
andrejtonev
force-pushed
the
mem_tracker_deadlock_fix
branch
from
b4171bf to
8d42a0a
Compare
|
as51340
pushed a commit
that referenced
this pull request
Oct 24, 2025
Memory tracker uses SkipLists. These can allocate memory during usage. Tracker was not ignoring these allocations, so would try to track the allocations caused by the tracking. Eventually getting blocked on the SkipList's lock_.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memory tracker uses SkipLists. These can allocate memory during usage.
Tracker was not ignoring these allocations, so would try to track the allocations caused by the tracking. Eventually getting blocked on the SkipList's lock_.