Skip to content

Better global settings error messages#2494

Merged
gitbuda merged 3 commits intomasterfrom
better_settings_messages
Nov 23, 2024
Merged

Better global settings error messages#2494
gitbuda merged 3 commits intomasterfrom
better_settings_messages

Conversation

@andrejtonev
Copy link
Contributor

@andrejtonev andrejtonev commented Nov 21, 2024

No description provided.

@andrejtonev andrejtonev changed the base branch from snapshot_scheduling to master November 21, 2024 17:47
@andrejtonev
Copy link
Contributor Author

andrejtonev commented Nov 21, 2024

Git commit description, explain the changes you made here

Leave above in PR description, copy the below into a comment

Tracking

  • [Link to Epic/Issue]

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [ Release note text ]
  • [ Documentation PR link memgraph/documentation#XXXX ]
    • Is back linked to this development PR
  • [ Tag someone from docs team ]

@andrejtonev andrejtonev force-pushed the better_settings_messages branch from 39fa8ff to 5cead80 Compare November 21, 2024 17:48
@andrejtonev andrejtonev changed the base branch from master to snapshot_scheduling November 21, 2024 17:48
Base automatically changed from snapshot_scheduling to master November 21, 2024 18:43
@gitbuda
Copy link
Member

gitbuda commented Nov 22, 2024

@andrejtonev, does it make sense to combine this change with #2379, or should these be two separate PRs? 🤔

@andrejtonev andrejtonev force-pushed the better_settings_messages branch from 5cead80 to dfb85e1 Compare November 22, 2024 08:47
@andrejtonev andrejtonev self-assigned this Nov 22, 2024
@andrejtonev andrejtonev added feature feature Docs needed Docs needed labels Nov 22, 2024
@andrejtonev
Copy link
Contributor Author

andrejtonev commented Nov 22, 2024

@gitbuda depends on when you want to merge this.
This could already be merged.

@gitbuda gitbuda enabled auto-merge November 22, 2024 19:48
@gitbuda gitbuda added this pull request to the merge queue Nov 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2024
@gitbuda gitbuda added the CI -build=debug -test=integration Run debug build and integration tests on push label Nov 23, 2024
@gitbuda gitbuda mentioned this pull request Nov 23, 2024
Merged
31 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 23, 2024

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@gitbuda gitbuda added this pull request to the merge queue Nov 23, 2024
@gitbuda gitbuda added this to the mg-v2.22.0 milestone Nov 23, 2024
Merged via the queue into master with commit 0a8c4b6 Nov 23, 2024
@gitbuda gitbuda deleted the better_settings_messages branch November 23, 2024 23:51
@andrejtonev andrejtonev added Docs unnecessary Docs unnecessary and removed Docs needed Docs needed labels Nov 25, 2024
as51340 pushed a commit that referenced this pull request Oct 24, 2025
@andrejtonev @gitbuda
Better global settings error messages (#2494)
9b65cc2 
Co-authored-by: Marko Budiselic <[email protected]>
Co-authored-by: Marko Budiselić <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gitbuda gitbuda gitbuda approved these changes

Assignees

@andrejtonev andrejtonev

Labels

breaking CI -build=debug -test=integration Run debug build and integration tests on push Docs unnecessary Docs unnecessary feature feature

Projects

None yet

Milestone

mg-v2.22.0

Development

Successfully merging this pull request may close these issues.

2 participants

@andrejtonev @gitbuda