Skip to content

Improve error messages#2379

Merged
andrejtonev merged 19 commits intomasterfrom
improve-error-messages
Feb 9, 2025
Merged

Improve error messages#2379
andrejtonev merged 19 commits intomasterfrom
improve-error-messages

Conversation

@gitbuda
Copy link
Member

@gitbuda gitbuda commented Oct 6, 2024 •
edited by andrejtonev
Loading

The main motivation here is to significantly improve error messages so that
they are much more useful in AI pipelines (e.g., based on insightful errors, an LLM
can make multiple attempts to work with Memgraph).

@gitbuda gitbuda added Docs - changelog only Docs - changelog only breaking labels Oct 6, 2024
@gitbuda gitbuda added this to the mg-v2.21.0 milestone Oct 6, 2024
@gitbuda gitbuda self-assigned this Oct 6, 2024
@gitbuda
Copy link
Member Author

gitbuda commented Oct 6, 2024 •
edited by andrejtonev
Loading

Antlr is a big part -> the upgrade to the latest version done under #2358

Tracking

  • [Link to Epic/Issue]

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Improved error messages that get sent to the user in cases of query failure. Better understanding of the issue that caused a query to fail and easier debugging. Better error messages also improve final results when in an AI pipeline. #2379
  • [ Documentation PR link memgraph/documentation#XXXX ]
    • Is back linked to this development PR
  • [ Tag someone from docs team ]

@gitbuda gitbuda added CI -build=release -test=core Run release build and core tests on push CI -build=release -test=stress Run release build and stress tests on push CI -build=release -test=benchmark Run release build and benchmark on push labels Oct 27, 2024
@gitbuda gitbuda requested a review from katarinasupe October 28, 2024 01:40
andrejtonev
andrejtonev reviewed Oct 28, 2024
View reviewed changes
@gitbuda gitbuda modified the milestones: mg-v2.21.0, mg-v2.22.0 Nov 6, 2024
@gitbuda gitbuda mentioned this pull request Nov 22, 2024
Merged
@andrejtonev andrejtonev force-pushed the improve-error-messages branch from 2767d40 to 537c0d8 Compare November 22, 2024 13:04
@gitbuda gitbuda added the CI -build=debug -test=integration Run debug build and integration tests on push label Nov 23, 2024
@gitbuda gitbuda mentioned this pull request Nov 23, 2024
Merged
31 tasks
@gitbuda gitbuda marked this pull request as ready for review November 23, 2024 21:47
@gitbuda gitbuda assigned andrejtonev and unassigned gitbuda Jan 27, 2025
@gitbuda gitbuda modified the milestones: mg-v3.0.0, mg-v3.1.0 Jan 27, 2025
@andrejtonev andrejtonev enabled auto-merge February 6, 2025 16:00
@andrejtonev
Copy link
Contributor

andrejtonev commented Feb 6, 2025

The full list of potential improvements can be found under
https://www.notion.so/memgraph/Review-and-improve-error-messages-99eea007219745c8ab9c7f7985b6f121

@andrejtonev andrejtonev added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025
@andrejtonev andrejtonev added CI -build=jepsen -test=core Run jepsen build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push and removed CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=stress Run release build and stress tests on push CI -build=release -test=benchmark Run release build and benchmark on push labels Feb 7, 2025
@andrejtonev andrejtonev enabled auto-merge February 9, 2025 11:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@andrejtonev andrejtonev added this pull request to the merge queue Feb 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2025
@andrejtonev andrejtonev added this pull request to the merge queue Feb 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2025
@andrejtonev andrejtonev added this pull request to the merge queue Feb 9, 2025
Merged via the queue into master with commit 1916e97 Feb 9, 2025
15 checks passed
@andrejtonev andrejtonev deleted the improve-error-messages branch February 9, 2025 19:26
@gitbuda gitbuda mentioned this pull request Mar 11, 2025
Merged
49 tasks
as51340 pushed a commit that referenced this pull request Oct 24, 2025
@gitbuda @andrejtonev @katarinasupe
Improve error messages (#2379)
34c7f06 
The main motivation here is to significantly improve error messages so
that
they are much more useful in AI pipelines (e.g., based on insightful
errors, an LLM
can make multiple attempts to work with Memgraph).

---------

Co-authored-by: Andreja Tonev <[email protected]>
Co-authored-by: andrejtonev <[email protected]>
Co-authored-by: Katarina Supe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrejtonev andrejtonev andrejtonev approved these changes

@katarinasupe katarinasupe katarinasupe left review comments

@tonilastre tonilastre Awaiting requested review from tonilastre

@Ana-Marija-design Ana-Marija-design Awaiting requested review from Ana-Marija-design

Assignees

@andrejtonev andrejtonev

Labels

breaking CI -build=jepsen -test=core Run jepsen build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push Docs - changelog only Docs - changelog only

Projects

None yet

Milestone

mg-v3.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@gitbuda @andrejtonev @katarinasupe