Conversation
Contributor
Author
TrackingStandard development
CI Testing Labels
Documentation checklist
|
Ignition
force-pushed
the
rtld_deepbind_removal
branch
from
6aea680 to
0d92e2c
Compare
as51340
approved these changes
Sep 24, 2024
Contributor
|
maybe it would be good to run test release workflows on each OS since there could be some differences |
Ignition
force-pushed
the
rtld_deepbind_removal
branch
from
0d92e2c to
055c1cb
Compare
|
This was referenced Oct 2, 2024
as51340
pushed a commit
that referenced
this pull request
Oct 24, 2025
In the past we had issues with RTLD_DEEPBIND. Some issues made a query module work because of RTLD_DEEPBIND, others would break because of RTLD_DEEPBIND. Advice is to remove RTLD_DEEPBIND and make most global symbols hidden. My belief is that most of the issues we were having were solved by the update to toolchain-v5 which used a newer libstdc++. I'm currently unable to reproduce the issue, so removing RTLD_DEEPBIND is a first step. Fixing symbol hiding will be done in a later PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past we had issues with RTLD_DEEPBIND.
Some issues made a query module work because of RTLD_DEEPBIND, others would break because of RTLD_DEEPBIND.
Advice is to remove RTLD_DEEPBIND and make most global symbols hidden.
My belief is that most of the issues we were having were solved by the update to toolchain-v5 which used a newer libstdc++. I'm currently unable to reproduce the issue, so removing RTLD_DEEPBIND is a first step. Fixing symbol hiding will be done in a later PR.