Skip to content

Introduce Spatial indexes #2298

Merged
Ignition merged 24 commits intomasterfrom
spatial-indexes
Sep 11, 2024
Merged

Introduce Spatial indexes #2298
Ignition merged 24 commits intomasterfrom
spatial-indexes

Conversation

@Ignition
Copy link
Contributor

@Ignition Ignition commented Aug 29, 2024 •
edited
Loading

Cypher modifications to CREATE + DROP point indexes. This includes the management and update of those indexes to have snapshot consistent index per transaction and update global copy of the index at commit.

@Ignition
Copy link
Contributor Author

Ignition commented Aug 29, 2024 •
edited
Loading

Tracking

  • [Link to Epic/Issue]

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Introduce spatial index machinery, currently not useful so remains undocumented until the next release
  • [ Documentation PR link memgraph/documentation#XXXX ]
    • Is back linked to this development PR
  • [ Tag someone from docs team ]

@Ignition Ignition added feature feature Docs needed Docs needed labels Aug 29, 2024
@Ignition Ignition added this to the mg-v2.20.0 milestone Aug 29, 2024
@Ignition Ignition added CI -build=community -test=core Run community build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=benchmark Run release build and benchmark on push labels Aug 30, 2024
@Ignition Ignition force-pushed the spatial-indexes branch 4 times, most recently from 86aa540 to 0675dd9 Compare September 4, 2024 08:28
@Ignition Ignition marked this pull request as ready for review September 4, 2024 10:59
Ignition
Ignition commented Sep 5, 2024
View reviewed changes
Ignition
Ignition commented Sep 5, 2024
View reviewed changes
as51340
as51340 reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked on the call. The logic seems to be good. 2 small things but the code looks great

Josipmrden
Josipmrden reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Josipmrden Josipmrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

Ignition
Ignition commented Sep 10, 2024
View reviewed changes
@Ignition Ignition removed CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=benchmark Run release build and benchmark on push labels Sep 11, 2024
@Ignition Ignition added this pull request to the merge queue Sep 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024
@Ignition Ignition added this pull request to the merge queue Sep 11, 2024
@Ignition Ignition removed this pull request from the merge queue due to a manual request Sep 11, 2024
@Ignition Ignition enabled auto-merge September 11, 2024 15:12
@Ignition Ignition added this pull request to the merge queue Sep 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024
@Ignition Ignition enabled auto-merge September 11, 2024 17:16
@Ignition Ignition added this pull request to the merge queue Sep 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024
@Ignition Ignition enabled auto-merge September 11, 2024 19:38
@Ignition Ignition added this pull request to the merge queue Sep 11, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 11, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
25.8% Duplication on New Code

See analysis details on SonarCloud

Merged via the queue into master with commit 9de1ec6 Sep 11, 2024
@Ignition Ignition deleted the spatial-indexes branch September 11, 2024 20:48
@Ignition Ignition added Docs unnecessary Docs unnecessary and removed Docs needed Docs needed breaking labels Sep 12, 2024
This was referenced Sep 28, 2024
Closed
Closed
as51340 pushed a commit that referenced this pull request Oct 24, 2025
@Ignition @imilinovic
Introduce Spatial indexes (#2298)
6c5391e 
Cypher modifications to CREATE + DROP point indexes. This includes the
management and update of those indexes to have snapshot consistent index
per transaction and update global copy of the index at commit.

---------

Co-authored-by: imilinovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Josipmrden Josipmrden Josipmrden left review comments

@imilinovic imilinovic imilinovic left review comments

@as51340 as51340 as51340 left review comments

@andrejtonev andrejtonev andrejtonev approved these changes

Assignees

@Ignition Ignition

@imilinovic imilinovic

Labels

Capability - spatial Docs unnecessary Docs unnecessary feature feature

Projects

None yet

Milestone

mg-v2.20.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Ignition @Josipmrden @andrejtonev @imilinovic @as51340