Edge index planning in sync with variable start planner#2293
Merged
Edge index planning in sync with variable start planner#2293
Conversation
…to edge-index-planning
…to edge-index-planning
Ignition
reviewed
Sep 11, 2024
Ignition
approved these changes
Sep 16, 2024
|
as51340
pushed a commit
that referenced
this pull request
Oct 24, 2025
Edge index planning made robust with the variable start planner like the node planning. Before this PR, the plans could only be generated with scanning of nodes, followed by expansion. Since we introduced edge indices based on edge type and edge-property type, the planner needs to be adjusted so it can generate a scanning of indexed edge triplets (from, edge, to) in order to perform valid expansion. If there is no edge index present, the plan will not be used, since we don't have a data structure that will iterate over all the edges and their triplets. That plan is invalid. All plans starting from an edge index are valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edge index planning made robust with the variable start planner like the node planning.
Before this PR, the plans could only be generated with scanning of nodes, followed by expansion. Since we introduced edge indices based on edge type and edge-property type, the planner needs to be adjusted so it can generate a scanning of indexed edge triplets (from, edge, to) in order to perform valid expansion.
If there is no edge index present, the plan will not be used, since we don't have a data structure that will iterate over all the edges and their triplets. That plan is invalid. All plans starting from an edge index are valid.