[master < T0706-MG] Support Bolt v4.3 protocol #226
Merged
antonio2368 merged 42 commits intomasterfrom Oct 28, 2021
Merged
Conversation
jbajic
requested review from
antaljanosbenjamin,
antonio2368,
gitbuda and
kostasrim
jbajic
force-pushed
the
T0706-MG-support-bolt-v4.3
branch
3 times, most recently
from
f454a4f to
9f5b0a6
Compare
Contributor
Author
|
These are the benchmarks from the last build: |
kostasrim
reviewed
Sep 12, 2021
Contributor
kostasrim
left a comment
kostasrim
left a comment
There was a problem hiding this comment.
There are some suggested improvements but overall good work. (This is my first review, there will be another one more detailed but this is enough to generate some good discussions/feedback)
jbajic
commented
Sep 13, 2021
jbajic
force-pushed
the
T0706-MG-support-bolt-v4.3
branch
from
e7275ca to
bb6813c
Compare
added 14 commits
October 13, 2021 10:16
antonio2368
reviewed
Oct 21, 2021
kostasrim
reviewed
Oct 21, 2021
antaljanosbenjamin
approved these changes
Oct 26, 2021
Contributor
antaljanosbenjamin
left a comment
antaljanosbenjamin
left a comment
There was a problem hiding this comment.
Don't forget the changelog!
antonio2368
reviewed
Oct 26, 2021
antonio2368
reviewed
Oct 26, 2021
antonio2368
reviewed
Oct 26, 2021
jbajic
force-pushed
the
T0706-MG-support-bolt-v4.3
branch
from
fb8fc44 to
1f7d4eb
Compare
antonio2368
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[master < Task] PR