Skip to content

Periodic commit syntax#2182

Merged
Josipmrden merged 19 commits intomasterfrom
periodic-commit-syntax
Aug 3, 2024
Merged

Periodic commit syntax#2182
Josipmrden merged 19 commits intomasterfrom
periodic-commit-syntax

Conversation

@Josipmrden
Copy link
Contributor

@Josipmrden Josipmrden commented Jul 5, 2024 •
edited
Loading

Grammar and syntax checking for periodic commit
Periodic commit can be specified in 2 ways:

  1. Top level with: USING PERIODIC COMMIT x <query> (where x is the number of rows after which we periodically commit)
  2. Subquery level with: CALL {<query>} IN TRANSACTIONS OF x ROWS (where x is the number of rows after which we periodically commit)

@Josipmrden
Copy link
Contributor Author

Josipmrden commented Jul 5, 2024 •
edited
Loading

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Added syntax for periodic commit query
  • Add periodic commit documentation documentation#935
    • Is back linked to this development PR
  • [ Tag someone from docs team ] @kgolubic

@Josipmrden Josipmrden marked this pull request as ready for review July 11, 2024 07:54
@Josipmrden Josipmrden added CI -build=debug -test=core Run debug build and core tests on push CI -build=release -test=core Run release build and core tests on push labels Jul 11, 2024
@Josipmrden Josipmrden self-assigned this Jul 11, 2024
@Josipmrden Josipmrden added feature feature Docs needed Docs needed customer customer labels Jul 11, 2024
@Josipmrden Josipmrden added this to the mg-v2.19.0 milestone Jul 11, 2024
@Josipmrden Josipmrden mentioned this pull request Jul 22, 2024
Merged
10 tasks
@Josipmrden Josipmrden enabled auto-merge August 3, 2024 09:37
@Josipmrden Josipmrden disabled auto-merge August 3, 2024 09:37
@Josipmrden Josipmrden enabled auto-merge August 3, 2024 09:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Josipmrden Josipmrden removed the CI -build=release -test=core Run release build and core tests on push label Aug 3, 2024
@Josipmrden Josipmrden added this pull request to the merge queue Aug 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 3, 2024
@Josipmrden Josipmrden added this pull request to the merge queue Aug 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 3, 2024
@Josipmrden Josipmrden added this pull request to the merge queue Aug 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 3, 2024
@Josipmrden Josipmrden added this pull request to the merge queue Aug 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 3, 2024
@Josipmrden Josipmrden added this pull request to the merge queue Aug 3, 2024
Merged via the queue into master with commit 368f375 Aug 3, 2024
@Josipmrden Josipmrden deleted the periodic-commit-syntax branch August 3, 2024 20:39
@gitbuda gitbuda mentioned this pull request Aug 7, 2024
Open
@kgolubic
Copy link
Contributor

kgolubic commented Aug 12, 2024

For release note I'll use:

  • Introduced new syntax for periodic commits.
    #2182

as51340 pushed a commit that referenced this pull request Oct 24, 2025
@Josipmrden
Periodic commit syntax (#2182)
38c1ea9 
Grammar and syntax checking for periodic commit
Periodic commit can be specified in 2 ways:
1. Top level with: `USING PERIODIC COMMIT x <query>` (where x is the
number of rows after which we periodically commit)
1. Subquery level with: `CALL {<query>} IN TRANSACTIONS OF x ROWS`
(where x is the number of rows after which we periodically commit)
@katarinasupe katarinasupe mentioned this pull request Jul 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Darych Darych Darych approved these changes

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Josipmrden Josipmrden

Labels

CI -build=debug -test=core Run debug build and core tests on push customer customer Docs needed Docs needed feature feature

Projects

None yet

Milestone

mg-v2.19.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Josipmrden @kgolubic @Darych @antoniofilipovic