Skip to content

Allow user to define a password directly via its hash#2148

Merged
andrejtonev merged 4 commits intomasterfrom
allow_userdefined_hashes
Aug 7, 2024
Merged

Allow user to define a password directly via its hash#2148
andrejtonev merged 4 commits intomasterfrom
allow_userdefined_hashes

Conversation

@andrejtonev
Copy link
Contributor

@andrejtonev andrejtonev commented Jun 28, 2024 •
edited
Loading

The user can now define their password via a hash.

@andrejtonev
Copy link
Contributor Author

andrejtonev commented Jun 28, 2024 •
edited
Loading

Tracking

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Users can now be identified directly via password hash instead of only via plain-text passwords
  • 950
    • Is back linked to this development PR
  • @hal-eisen-MG

@andrejtonev andrejtonev force-pushed the allow_userdefined_hashes branch from ddbc8b1 to c865f74 Compare June 28, 2024 07:02
@andrejtonev andrejtonev self-assigned this Jun 28, 2024
@andrejtonev andrejtonev added CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push Docs needed Docs needed Capability - security labels Jun 28, 2024
@antejavor
Copy link
Contributor

antejavor commented Jun 28, 2024

Related issue: #2145

@andrejtonev andrejtonev added benchmarking mgBench and benchmarking Memgraph CI -build=release -test=benchmark Run release build and benchmark on push and removed benchmarking mgBench and benchmarking Memgraph labels Jun 28, 2024
@andrejtonev andrejtonev force-pushed the allow_userdefined_hashes branch from c865f74 to 84d6667 Compare June 28, 2024 10:54
@andrejtonev andrejtonev marked this pull request as ready for review June 28, 2024 10:57
@andrejtonev andrejtonev requested a review from Ignition June 28, 2024 10:57
@andrejtonev andrejtonev added the feature feature label Jun 28, 2024
Ignition
Ignition reviewed Jul 1, 2024
View reviewed changes
@antepusic antepusic linked an issue Jul 4, 2024 that may be closed by this pull request
Implement support for passing encrypted password. #2145
Closed
@andrejtonev andrejtonev added this to the mg-v2.19.0 milestone Jul 24, 2024
@andrejtonev
Copy link
Contributor Author

andrejtonev commented Jul 24, 2024

@tonijurjevic96
I need to resolve PR comments, but we also need to check if your password hiding work here as well.
It should, I just need a reminder to check.

@andrejtonev andrejtonev force-pushed the allow_userdefined_hashes branch from 84d6667 to 98af08e Compare July 24, 2024 15:18
@andrejtonev andrejtonev requested a review from Ignition July 25, 2024 10:01
@andrejtonev andrejtonev mentioned this pull request Jul 25, 2024
Merged
10 tasks
@andrejtonev andrejtonev removed the CI -build=release -test=benchmark Run release build and benchmark on push label Jul 29, 2024
@andrejtonev andrejtonev force-pushed the allow_userdefined_hashes branch 2 times, most recently from cd71cba to 945be9a Compare July 29, 2024 12:14
@andrejtonev andrejtonev force-pushed the allow_userdefined_hashes branch from 945be9a to 5a6233a Compare August 1, 2024 15:18
@andrejtonev andrejtonev added this pull request to the merge queue Aug 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2024
@andrejtonev andrejtonev added this pull request to the merge queue Aug 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2024
@andrejtonev andrejtonev added this pull request to the merge queue Aug 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2024
@andrejtonev andrejtonev added this pull request to the merge queue Aug 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 3, 2024
@andrejtonev andrejtonev enabled auto-merge August 7, 2024 13:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@andrejtonev andrejtonev added this pull request to the merge queue Aug 7, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 7, 2024
@andrejtonev
Allow user to define a password directly via its hash (#2148)
47865d9 
The user can now define their password via a hash.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2024
@andrejtonev andrejtonev added this pull request to the merge queue Aug 7, 2024
Merged via the queue into master with commit 3a2190a Aug 7, 2024
@andrejtonev andrejtonev deleted the allow_userdefined_hashes branch August 7, 2024 17:49
@kgolubic
Copy link
Contributor

kgolubic commented Aug 12, 2024

For release note I'll use:

  • Users can now define their passwords directly using a hash, allowing for more
    secure authentication methods by bypassing the need to store or transmit
    plain-text passwords. #2148

as51340 pushed a commit that referenced this pull request Oct 24, 2025
@andrejtonev
Allow user to define a password directly via its hash (#2148)
3d7a9d1 
The user can now define their password via a hash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ignition Ignition Ignition approved these changes

Assignees

@andrejtonev andrejtonev

Labels

Capability - security CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push Docs needed Docs needed feature feature

Projects

None yet

Milestone

mg-v2.19.0

Development

Successfully merging this pull request may close these issues.

Implement support for passing encrypted password.

4 participants

@andrejtonev @antejavor @kgolubic @Ignition