Conversation
as51340
commented
May 22, 2024
andrejtonev
reviewed
May 22, 2024
6314cf1 to
5128029
Compare
andrejtonev
reviewed
May 23, 2024
andrejtonev
approved these changes
May 24, 2024
Contributor
andrejtonev
left a comment
There was a problem hiding this comment.
Just remove the version from the ReplicaEntry and that's it.
💪
|
Contributor
|
@as51340 I'll use this as RN:
|
as51340
added a commit
that referenced
this pull request
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
ReplicationServerConfigis now usingEndpointstruct.ReplicationClientConfigis now usingEndpointstruct.replica_serverkey,replica_ip_addressisn't used anymore.to_jsonis now serializing only the latest versions.ReplicationReplicaEntryis also usingDurabilityVersionbut implicitly throughReplicationRoleEntry.[master < Task] PR
CI Testing Labels
Please select the appropriate CI test labels (CI -build=build-name -test=test-suite)
Documentation checklist