Things that I'm not sure yet and looking for pointers @gvolfing @Ignition :

• How to best make the singleton out of the interpreter context? -> i set it to raw pointer for now, I still have to make the instance constructor private because it's a singleton, need thoughts on this -> UPDATE: Set it to unique pointer so cleanup is ensured, perhaps everything is okay now, still need to make the constructor private

• Can it be a singleton, if we have MT? UPDATE: Added support for multi-tenancy, but database name needs to be kept in the interpreter and updated

• Lifetime of pointers in the API -> pls check if I did this correctly

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Josipmrden is there a related docs PR?

API works 🎊

Just small observation:

/hello_query_module/hello_query_module.cpp:28:45: error: call to member function 'ExecuteQuery' is ambiguous
        mgp::QueryExecution(memgraph_graph).ExecuteQuery("MATCH n RETURN n;");
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~

Non-casted string leads to ambiguity by the compiler due to multiple versions:

class QueryExecution {
 public:
  QueryExecution(mgp_graph *graph);
  ExecutionResult ExecuteQuery(std::string_view query, Map params = Map()) const;
  ExecutionResult ExecuteQuery(std::string query, Map params = Map()) const;

    auto res = mgp::QueryExecution(memgraph_graph)
                   .ExecuteQuery(std::string("MATCH n RETURN n;"));

Do you know if the two versions are necessary? @Josipmrden