Skip to content

Add filtering details to EXPLAIN and PROFILE#1265

Merged
antoniofilipovic merged 20 commits intomasterfrom
filter-info
Oct 25, 2023
Merged

Add filtering details to EXPLAIN and PROFILE#1265
antoniofilipovic merged 20 commits intomasterfrom
filter-info

Conversation

@antepusic
Copy link
Contributor

@antepusic antepusic commented Sep 18, 2023

This PR extends the EXPLAIN and PROFILE clauses with detailed information about the Filter operator.

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

Add detailed Filter operator info to EXPLAIN and PROFILE clauses

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses

We’ve improved query inspection using EXPLAIN and PROFILE clauses by adding information about the operands of the Filter operator.

  • Tag someone from docs team in the comments

@antepusic antepusic self-assigned this Sep 18, 2023
@antepusic antepusic added feature feature Ready for review PR is ready for review Docs needed Docs needed and removed draft labels Sep 18, 2023
@antepusic antepusic marked this pull request as ready for review September 18, 2023 20:52
@as51340
Copy link
Contributor

as51340 commented Sep 19, 2023

Good job Ante, I have few ideas how to improve it and good to go

@antepusic antepusic requested a review from as51340 September 19, 2023 10:31
Copy link
Contributor

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adopt the change in this comment or don't it is up to you, LGTM

@gitbuda gitbuda added this to the mg-v2.12.0 milestone Sep 19, 2023
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, good job!

@antoniofilipovic antoniofilipovic added Needs change PR needs change and removed Ready for review PR is ready for review labels Sep 20, 2023
@gitbuda gitbuda changed the title [master < T1265] Add filtering details to EXPLAIN and PROFILE Add filtering details to EXPLAIN and PROFILE Sep 24, 2023
@antepusic antepusic added Ready for review PR is ready for review and removed Needs change PR needs change labels Oct 23, 2023
@antepusic
Copy link
Contributor Author

@vpavicic Release note in the original comment

@antoniofilipovic antoniofilipovic merged commit 3158a16 into master Oct 25, 2023
@antoniofilipovic antoniofilipovic deleted the filter-info branch October 25, 2023 19:36
antepusic added a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs needed Docs needed feature feature Ready for review PR is ready for review

Projects

No open projects
Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

4 participants