Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

[E-graphQL < T-collections] Change collections to abide by graphQL#361

Merged
mpintaric55334 merged 4 commits intoE-graphQL-compatibilityfrom
T-proc2func-coll
Sep 22, 2023
Merged

[E-graphQL < T-collections] Change collections to abide by graphQL#361
mpintaric55334 merged 4 commits intoE-graphQL-compatibilityfrom
T-proc2func-coll

Conversation

@mpintaric55334
Copy link
Contributor

Description

Please briefly explain the changes you made here.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@mpintaric55334 mpintaric55334 added the status: ready PR is ready for review label Sep 18, 2023
@mpintaric55334 mpintaric55334 self-assigned this Sep 18, 2023
@mpintaric55334 mpintaric55334 added status: draft PR is in draft phase and removed status: ready PR is ready for review labels Sep 18, 2023
@mpintaric55334 mpintaric55334 added status: ready PR is ready for review and removed status: draft PR is in draft phase labels Sep 18, 2023
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes to do, but looks good

@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Sep 19, 2023
@mpintaric55334 mpintaric55334 added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Sep 19, 2023
Copy link
Contributor

@imilinovic imilinovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Looks good!

Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to go

@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Sep 22, 2023
@antoniofilipovic antoniofilipovic added this to the 1.11.1 milestone Sep 22, 2023
@antoniofilipovic antoniofilipovic added the Docs needed Docs needed label Sep 22, 2023
@mpintaric55334 mpintaric55334 merged commit 3fc6c32 into E-graphQL-compatibility Sep 22, 2023
@mpintaric55334 mpintaric55334 deleted the T-proc2func-coll branch September 22, 2023 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Docs needed Docs needed status: ship it PR approved

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants