This repository was archived by the owner on Jan 23, 2026. It is now read-only.
Merged
Conversation
antoniofilipovic
requested review from
Josipmrden,
antepusic,
as51340 and
brunos252
Josipmrden
reviewed
Jan 23, 2023
setup
Outdated
| cmake_args.append(f"-D{MAGE_GPU_BUILD}") | ||
| if args.cpp_build_flags is not None: | ||
| cmake_args += [f"-D{flag}" for flag in args.cpp_build_flags] | ||
| if args["cpp_build_flags"] is not None: |
Contributor
There was a problem hiding this comment.
extract args constants in enum or class with predefined values
antepusic
suggested changes
Jan 24, 2023
Contributor
antepusic
left a comment
antepusic
left a comment
There was a problem hiding this comment.
The code looks good; suggesting several fixes to make the README more user-friendly and errors more helpful.
Co-authored-by: Ante Pušić <[email protected]>
…ge into T560-FL-update-setup-to-fail
antepusic
suggested changes
Jan 25, 2023
Contributor
antepusic
left a comment
antepusic
left a comment
There was a problem hiding this comment.
Just notifying you about a few more issues I caught.
Co-authored-by: Ante Pušić <[email protected]>
antepusic
suggested changes
Jan 26, 2023
Contributor
antepusic
left a comment
antepusic
left a comment
There was a problem hiding this comment.
Just fix these bits before I approve! 🚀
Co-authored-by: Ante Pušić <[email protected]>
antepusic
added
status: ship it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pull request type
Related issues
Solves issue @tonilastre mentioned for Cloud
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################