Fix JS button example (#42503) #42509
Open
+3
−569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs(HTML): add note about sandboxed download in <a> example mdn#42463
This PR fixes the first JavaScript code example on the page: 'Player 1: Chris' button. - Added <script src="script.js"> below button in HTML - Corrected JS order: select button first, then define function and add event listener - Ensures dynamic behavior works in MDN Playground
kashish2710
requested review from
hamishwillee
and removed request for
a team
github-actions
bot
added
Content:HTML
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| To save a {{HTMLElement("canvas")}} element's contents as an image, you can create a link where the `href` is the canvas data as a `data:` URL created with JavaScript and the `download` attribute provides the file name for the downloaded PNG file: | ||
|
|
||
| > **Note:** The "Download my painting" link will not work in MDN live examples because downloads are disabled in sandboxed iframes. |
Contributor
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
Suggested change
| > **Note:** The "Download my painting" link will not work in MDN live examples because downloads are disabled in sandboxed iframes. | |
| > **Note:** The "Download my painting" link will not work in MDN live examples because downloads are disabled in sandboxed iframes. |
|
|
||
| To save a {{HTMLElement("canvas")}} element's contents as an image, you can create a link where the `href` is the canvas data as a `data:` URL created with JavaScript and the `download` attribute provides the file name for the downloaded PNG file: | ||
|
|
||
| > **Note:** The "Download my painting" link will not work in MDN live examples because downloads are disabled in sandboxed iframes. |
Contributor
There was a problem hiding this comment.
[markdownlint] reported by reviewdog 🐶
error search-replace Custom rule [gfm-alert: Use the GFM syntax: https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Howto/Markdown_in_MDN#notes_warnings_and_callouts] [Context: "column: 1 text:'> Note:'"]
Contributor
|
Preview URLs Flaws (1)URL:
(comment last updated: 2025-12-23 11:15:24) |
github-actions
bot
added
size/l
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42503
const buttondeclaration before theupdateNamefunction so the JS example works correctly.<script defer src="script.js"></script>to ensure JS runs after page loads.