Add dialog invoker command documentation and example #42506
+98
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MUSKANNISHAD
requested review from
hamishwillee
and removed request for
a team
github-actions
bot
added
Content:HTML
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| ctx.stroke(path2); | ||
| ``` | ||
| ## Specifications |
Contributor
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
Suggested change
| ## Specifications | |
| ## Specifications |
Author
|
Hi maintainers 👋 Could you please review when you get a chance? |
hamishwillee
force-pushed
the
dialog-command-docs
branch
from
127d279 to
681165f
Compare
Contributor
|
Preview URLs |
Collaborator
hamishwillee
left a comment
hamishwillee
left a comment
There was a problem hiding this comment.
@MUSKANNISHAD I removed all the spurious unrelated commits on path 2d, merged the remainder and rebased. It is best not to mix PRs about different things.
However this is still a bit unreviewable - see line 76. Did you review this locally to see how the changes rendered? Did you move the accessibility section or change it?
I might not get back to this until well in the new year.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the documentation by explaining how invoker commands and the button
commandattribute interact with dialogs, and adds a small example demonstrating their usage.The dialog page did not previously explain how invoker commands apply to dialogs, even though this functionality is part of the HTML standard and documented elsewhere. This change helps readers understand how dialogs can be opened and closed using declarative commands without custom JavaScript.
Fixes #42121