Fix #12150 FP uninitialized member array, initialized in range for loop (cppcheck-opensource#5627)

chrchr-github · web-flow · commit de2cfb05b058 · 2023-11-06T16:15:47.000+01:00
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -1063,6 +1063,11 @@ void CheckClass::initializeVarList(const Function &func, std::list<const Functio
             assignVar(usage, ftok->next()->varId());
         } else if (Token::Match(ftok, "* this . %name% =")) {
             assignVar(usage, ftok->tokAt(3)->varId());
+        } else if (astIsRangeBasedForDecl(ftok)) {
+            if (const Variable* rangeVar = ftok->astParent()->astOperand1()->variable()) {
+                if (rangeVar->isReference() && !rangeVar->isConst())
+                    assignVar(usage, ftok->varId());
+            }
         }
 
         // The functions 'clear' and 'Clear' are supposed to initialize variable.
diff --git a/test/testconstructors.cpp b/test/testconstructors.cpp
@@ -193,6 +193,7 @@ class TestConstructors : public TestFixture {
         TEST_CASE(uninitVarArray8);
         TEST_CASE(uninitVarArray9); // ticket #6957, #6959
         TEST_CASE(uninitVarArray10);
+        TEST_CASE(uninitVarArray11);
         TEST_CASE(uninitVarArray2D);
         TEST_CASE(uninitVarArray3D);
         TEST_CASE(uninitVarCpp11Init1);
@@ -3180,6 +3181,20 @@ class TestConstructors : public TestFixture {
                       errout.str());
     }
 
+    void uninitVarArray11() {
+        check("class C {\n" // #12150
+              "private:\n"
+              "    int buf[10];\n"
+              "public:\n"
+              "    C() {\n"
+              "        for (int& i : buf)\n"
+              "            i = 0;\n"
+              "    }\n"
+              "};\n");
+
+        ASSERT_EQUALS("", errout.str());
+    }
+
     void uninitVarArray2D() {
         check("class John\n"
               "{\n"
