TST: Reset tolerances on tests changed by text overhaul#31303
Draft
QuLogic wants to merge 8 commits intomatplotlib:text-overhaulfrom
Draft
TST: Reset tolerances on tests changed by text overhaul#31303QuLogic wants to merge 8 commits intomatplotlib:text-overhaulfrom
QuLogic wants to merge 8 commits intomatplotlib:text-overhaulfrom
Conversation
- `test_backend_ps::test_type3_font` is covered by `test_backend_ps::test_multi_font_type3` - `test_text::test_pdf_chars_beyond_bmp` is covered by `test_backend_pdf::test_multi_font_type3` and `test_backend_pdf::test_multi_font_type42` - `test_text::test_pdf_kerning` is covered by `test_backend_pdf::test_kerning` - `test_text::test_pdf_type42_kerning` is covered by `test_backend_pdf::test_kerning`
These tests had previously kept some code or settings to prevent regenerating the test image, but since they are now going to be regenerated from the text overhaul, we can remove those.
github-project-automation
bot
moved this to Waiting for other PR
in Font and text overhaul
github-actions
bot
added
topic: mplot3d
and removed
status: waiting for other PR
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Now that these have been regenerated, we can reset the tolerances. It is possible that we may still need some architecture-specific tolerances; I will restore them if we find that to be the case in CI here.
Only the last commit is relevant here.
AI Disclosure
None
PR checklist