Added Differentiate3 to Interpolation#1093
Conversation
osswaldo
force-pushed
the
interpolation_differentiate3
branch
from
74febe3 to
3cc5b65
Compare
|
I would like to see some unit tests for this. |
|
I tool a closer look into the tests and there aren't any tests for the Differentiate methods at all. |
|
Maybe we can start now having tests for it? |
osswaldo
force-pushed
the
interpolation_differentiate3
branch
from
3cc5b65 to
6115680
Compare
|
Ok, done ;) |
osswaldo
force-pushed
the
interpolation_differentiate3
branch
from
6115680 to
243d516
Compare
|
This is awesome, thank you |
| /// </summary> | ||
| /// <param name="t">Point t to interpolate at.</param> | ||
| /// <returns>Interpolated third derivative at point t.</returns> | ||
| double Differentiate3(double t); |
There was a problem hiding this comment.
Adding a method to IInterpolation is a breaking change since IInterpolation is a public interface that consumers of the library can and do implement.
Might be better to leave it out of the interface but keep the method for the classes for which the method is supported.
|
It’s been more than 2 years that the latest 5.0 release of the library has been published. I’m not the official maintainer but I wouldn’t have something against releasing a 5.1 version with this change among others (it’s adding a feature, not removing existing ones or changing functionality) |
|
It isn't a realy "breaking" change if one extend an interface. You can simply implement the method as not implemented. However, it could be make sence to introduce an IDifferentiableInterpolation in order to remove the SupportsDifferentiation property. |
|
I am wondering what is the current state of this PR? Will it be merged? |
3 participants
No description provided.