mobile:pinchOpen and mobile:pinchClose no longer implemented in appium drivers (appium#358)

Jonahss · KazuCocoa · commit 984e57249f2e · 2019-05-01T11:22:37.000+09:00
diff --git a/README.md b/README.md
@@ -408,15 +408,6 @@ self.driver.tap(positions)
 
 Swipe from one point to another point.
 
-#### `driver.zoom`
-
-Zoom in on an element, doing a pinch out operation.
-
-#### `driver.pinch`
-
-Zoom out on an element, doing a pinch in operation.
-
-
 
 ### Application management methods
 
diff --git a/appium/webdriver/extensions/action_helpers.py b/appium/webdriver/extensions/action_helpers.py
@@ -134,47 +134,3 @@ def flick(self, start_x, start_y, end_x, end_y):
             .release()
         action.perform()
         return self
-
-    def pinch(self, element=None, percent=200, steps=50):
-        """Pinch on an element a certain amount
-
-        :Args:
-         - element - the element to pinch
-         - percent - (optional) amount to pinch. Defaults to 200%
-         - steps - (optional) number of steps in the pinch action
-
-        :Usage:
-            driver.pinch(element)
-        """
-        if element:
-            element = element.id
-
-        opts = {
-            'element': element,
-            'percent': percent,
-            'steps': steps,
-        }
-        self.execute_script('mobile: pinchClose', opts)
-        return self
-
-    def zoom(self, element=None, percent=200, steps=50):
-        """Zooms in on an element a certain amount
-
-        :Args:
-         - element - the element to zoom
-         - percent - (optional) amount to zoom. Defaults to 200%
-         - steps - (optional) number of steps in the zoom action
-
-        :Usage:
-            driver.zoom(element)
-        """
-        if element:
-            element = element.id
-
-        opts = {
-            'element': element,
-            'percent': percent,
-            'steps': steps,
-        }
-        self.execute_script('mobile: pinchOpen', opts)
-        return self
diff --git a/test/functional/android/multi_action_tests.py b/test/functional/android/multi_action_tests.py
@@ -120,52 +120,6 @@ def test_driver_multi_tap(self):
         self.driver.tap(positions)
         sleep(10)
 
-    def test_driver_pinch(self):
-        el1 = self.driver.find_element_by_name('Content')
-        el2 = self.driver.find_element_by_name('Animation')
-        self.driver.scroll(el1, el2)
-
-        el = self.driver.find_element_by_name('Views')
-        action = TouchAction(self.driver)
-        action.tap(el).perform()
-
-        els = self.driver.find_elements_by_class_name('android.widget.TextView')
-        self.driver.scroll(els[len(els) - 1], els[0])
-
-        els = self.driver.find_elements_by_class_name('android.widget.TextView')
-        if els[len(els) - 1].get_attribute('name') != 'WebView':
-            self.driver.scroll(els[len(els) - 1], els[0])
-
-        el = self.driver.find_element_by_name('WebView')
-        action.tap(el).perform()
-
-        sleep(SLEEPY_TIME)
-        el = self.driver.find_element_by_id('com.example.android.apis:id/wv1')
-        self.driver.pinch(element=el)
-
-    def test_driver_zoom(self):
-        el1 = self.driver.find_element_by_name('Content')
-        el2 = self.driver.find_element_by_name('Animation')
-        self.driver.scroll(el1, el2)
-
-        el = self.driver.find_element_by_name('Views')
-        action = TouchAction(self.driver)
-        action.tap(el).perform()
-
-        els = self.driver.find_elements_by_class_name('android.widget.TextView')
-        self.driver.scroll(els[len(els) - 1], els[0])
-
-        els = self.driver.find_elements_by_class_name('android.widget.TextView')
-        if els[len(els) - 1].get_attribute('name') != 'WebView':
-            self.driver.scroll(els[len(els) - 1], els[0])
-
-        el = self.driver.find_element_by_name('WebView')
-        action.tap(el).perform()
-
-        sleep(SLEEPY_TIME)
-        el = self.driver.find_element_by_id('com.example.android.apis:id/wv1')
-        self.driver.zoom(element=el)
-
 
 if __name__ == "__main__":
     suite = unittest.TestLoader().loadTestsFromTestCase(MultiActionTests)
diff --git a/test/functional/ios/multi_action_tests.py b/test/functional/ios/multi_action_tests.py
