Pass throwOnError: true when calling container.Export in unit tests #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without it the `ExportRunningContainerExploadedShallSucceed` test would fail (Assert.IsTrue failed) but hides the actual cause of the error:
```
Ductus.FluentDocker.Common.FluentDockerException: Exception while un-taring archive ---> SharpCompress.Common.ExtractionException: Entry is a symbolic link but ExtractionOptions.WriteSymbolicLink delegate is null
at SharpCompress.Common.ExtractionMethods.WriteEntryToFile(IEntry entry, String destinationFileName, ExtractionOptions options, Action`2 openAndWrite)
at SharpCompress.Readers.IReaderExtensions.WriteEntryToFile(IReader reader, String destinationFileName, ExtractionOptions options)
at SharpCompress.Common.ExtractionMethods.WriteEntryToDirectory(IEntry entry, String destinationDirectory, ExtractionOptions options, Action`2 write)
at SharpCompress.Readers.IReaderExtensions.WriteEntryToDirectory(IReader reader, String destinationDirectory, ExtractionOptions options)
at Ductus.FluentDocker.Extensions.CompressionExtensions.UnTar(String file, String destPath) in Ductus.FluentDocker/Extensions/CompressionExtensions.cs:line 19
at Ductus.FluentDocker.Services.Extensions.ContainerExtensions.Export(IContainerService service, TemplateString fqPath, Boolean explode, Boolean throwOnError) in Ductus.FluentDocker/Services/Extensions/ContainerExtensions.cs:line 125
--- End of inner exception stack trace ---
at Ductus.FluentDocker.Services.Extensions.ContainerExtensions.Export(IContainerService service, TemplateString fqPath, Boolean explode, Boolean throwOnError) in Ductus.FluentDocker/Services/Extensions/ContainerExtensions.cs:line 133
at Ductus.FluentDocker.Tests.ServiceTests.ContainerServiceBasicTests.ExportRunningContainerExploadedShallSucceed() in Ductus.FluentDocker.Tests/ServiceTests/ContainerServiceBasicTests.cs:line 268
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without it the
ExportRunningContainerExploadedShallSucceedtest would fail (Assert.IsTrue failed) but hides the actual cause of the error: