Skip to content

fix(sql): use dynamic import instead of require to fix command execution in esm environments #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pxDot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(sql): use dynamic import instead of require to fix command execution in esm environments #685

pxDot wants to merge 1 commit into from
+1 −1

Conversation

@pxDot
Copy link
Contributor

@pxDot pxDot commented Jan 1, 2026 •
edited
Loading

Summary of changes

Replace require with dynamic import to make it possible to create migrations in ESM projects.
Without this fix executing the migration:up CLI command will fail in ESM projects with the following error:

The command "migration:create" failed.
ReferenceError: require is not defined
    at MigrationCreateController.execute (file:///home/[redacted]/[redacted]/[redacted]/node_modules/.pnpm/@[email protected]_31dfc4400a8ec8e24849ce756645ed23/node_modules/@deepkit/sql/dist/esm/src/cli/migration-create-command.js:105:32)
    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)
    at async runCommand (file:///home/[redacted]/[redacted]/[redacted]/node_modules/.pnpm/@[email protected]_20843fe189e7fb277e8cf388d1d7bb0b/node_modules/@deepkit/app/dist/esm/src/command.js:611:28)
    at async executeCommand (file:///home/[redacted]/[redacted]/[redacted]/node_modules/.pnpm/@[email protected]_20843fe189e7fb277e8cf388d1d7bb0b/node_modules/@deepkit/app/dist/esm/src/command.js:363:16)
    at async App.execute (file:///home/[redacted]/[redacted]/[redacted]/node_modules/.pnpm/@[email protected]_20843fe189e7fb277e8cf388d1d7bb0b/node_modules/@deepkit/app/dist/esm/src/app.js:314:20)
    at async App.run (file:///home/[redacted]/[redacted]/[redacted]/node_modules/.pnpm/@[email protected]_20843fe189e7fb277e8cf388d1d7bb0b/node_modules/@deepkit/app/dist/esm/src/app.js:270:26)

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pxDot