Add some examples#260
Merged
TinyuZhao merged 24 commits intom5stack:masterfrom Sep 3, 2021
TinyuZhao:master
Merged
Conversation
Contributor
|
@Tinyu-Zhao
Usually, after submitting a pull request, you should not make any other changes until it is merged. |
Member
Author
|
Sorry, I don’t know that this will cause a lot of emails to be sent, I will try to work in other branches
Tinyu Chiu
2021年9月3日 +0800 08:39 lovyan03 ***@***.***>，写道：
… @Tinyu-Zhao
Why do you keep committing pull requests before they are merged?
I'm very tired of getting a lot of useless notifications because of you.
Usually, after submitting a pull request, you should not make any other changes until it is merged.
You should work in separate branches.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Contributor
|
@Tinyu-Zhao |
Member
Author
|
Thank you for your reminder, otherwise I might keep this wrong bad habit
Tinyu Chiu
2021年9月3日 +0800 08:48 lovyan03 ***@***.***>，写道：
… @Tinyu-Zhao
When you submit a pull request, don't make any changes to the branch until it has been merged, rejected, or concluded in some other way.
A pull request should be submitted when the change work is complete and ready to be safely merged.
You should not submit a pull request from a branch you are working on.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.