ZOOM Platform runner/service implementation #6126
Conversation
|
seems to be type issues, haven't tested but seems should be: - def get_library(self) -> List[dict]:
+ def get_library(self) -> Dict:
- def get_installer_url(self, game_slug: str, appid: str) -> str:
+ def get_installer_url(self, game_slug: str, appid: str) -> List:you can spot this by using a venv then Hope this helps and good luck, seems interesting (despite not knowing/using this platform) 👍 |
|
Removed most of the hacks, now the code looks very similar to the gog one, with a few simplifications |
neuromancer
changed the title
|
Just finished added the code to download extra content from games and it seems to work. I don't plan to implement any other feature. This code is ready for an initial review. |
|
I had to rename to |
neuromancer
changed the title
danieljohnson2
left a comment
danieljohnson2
left a comment
There was a problem hiding this comment.
My main takeaway here is that you haven't separated Zoom for GOG well enough. There's some overlap, but mostly there's a bunch of leftovers from the GOG service that you do not need.
If you have methods that you yourself do not call, search the code base to see if anybody does call that method. If it is only the GOG service, you don't need that method.
danieljohnson2
left a comment
danieljohnson2
left a comment
There was a problem hiding this comment.
I found nothing substantial, just a few little things. I don't think there's that much difference between this and the previous Zoom effort, really.
| """Return a mapping of available services""" | ||
| _services = { | ||
| "gog": GOGService, | ||
| "zoomplatform": ZoomService, |
There was a problem hiding this comment.
I'd have expected the service name to be "zoom" here. What is up with "platform"?
3 participants
I started to add the Zoom Platform to Lutris. I'd appreciate feedback and hope we can clean things up together to get this integrated.