Create route for externally-managed triggers that run only once#128
Merged
tmccombs merged 1 commit intoFeb 13, 2026
Merged
Conversation
tmccombs
requested changes
Jan 9, 2026
aegbert5
force-pushed
the
create-state-for-single-run-triggers
branch
2 times, most recently
from
b44be52 to
78d57ed
Compare
aegbert5
force-pushed
the
create-state-for-single-run-triggers
branch
6 times, most recently
from
a7c8451 to
3aba153
Compare
hunterrees
requested changes
Jan 13, 2026
hunterrees
requested changes
Jan 16, 2026
hunterrees
left a comment
hunterrees
left a comment
There was a problem hiding this comment.
I'm not ready to approve yet, but if we keep this approach I don't think we'll need changes. I'd like to discuss the option I outlined of not creating a new table before we proceed.
aegbert5
force-pushed
the
create-state-for-single-run-triggers
branch
6 times, most recently
from
3df4be0 to
8449c7c
Compare
hunterrees
approved these changes
Jan 22, 2026
Contributor
|
You should probably update the description, since it doesn't involve creating a database anymore. |
aegbert5
force-pushed
the
create-state-for-single-run-triggers
branch
from
8449c7c to
20b65a3
Compare
aegbert5
changed the title
tmccombs
requested changes
Jan 28, 2026
aegbert5
force-pushed
the
create-state-for-single-run-triggers
branch
3 times, most recently
from
6fbbb6e to
de07e18
Compare
aegbert5
force-pushed
the
create-state-for-single-run-triggers
branch
2 times, most recently
from
4d096b9 to
85d8814
Compare
tmccombs
requested changes
Jan 30, 2026
tmccombs
left a comment
tmccombs
left a comment
Contributor
There was a problem hiding this comment.
Almost there.
But you need to actually check the value of your EXISTS query, and your test isn't actually testing that we don't insert a duplicate record.
tmccombs
reviewed
Jan 30, 2026
tmccombs
reviewed
Jan 30, 2026
aegbert5
force-pushed
the
create-state-for-single-run-triggers
branch
7 times, most recently
from
145235f to
6fe78d7
Compare
aegbert5
force-pushed
the
create-state-for-single-run-triggers
branch
from
6fe78d7 to
f6eee6b
Compare
hunterrees
approved these changes
Feb 4, 2026
aegbert5
force-pushed
the
create-state-for-single-run-triggers
branch
from
f6eee6b to
381768b
Compare
tmccombs
approved these changes
Feb 5, 2026
| private final val prefixForOneTimeJobs = "ONE_TIME_" | ||
| final def oneTimeFireInstanceId(id: Long): String = prefixForOneTimeJobs + id.toString() | ||
| private final val triggerKeyGroup = "ONE_TIME_JOB" | ||
| final def oneTimeTriggerKey(fireInstanceId: Long): TriggerKey = TriggerKey(fireInstanceId.toString, triggerKeyGroup) |
Contributor
There was a problem hiding this comment.
Do we really want to use the instance id for the trigger name? Would it be better to use the job name or something?
Author
There was a problem hiding this comment.
In the UI, the trigger name and group will be displayed to indicate recent executions of the job. I think the instance id as a trigger name is a lot more intuitive than just presenting the name of the job you are running. This is what the UI looks like
aegbert5
force-pushed
the
create-state-for-single-run-triggers
branch
2 times, most recently
from
eb219e7 to
ea1115d
Compare
hunterrees
approved these changes
Feb 9, 2026
There was a problem hiding this comment.
We'll need to manually apply this patch everywhere unfortunately (we probably don't care as much about dev/staging though)
tmccombs
approved these changes
Feb 9, 2026
Contributor
There was a problem hiding this comment.
I wonder if we should flatten these patches, so that there is just a single sql file you run to set up the tables (but keep the patches files so you can migrate existing DBs?)
Author
There was a problem hiding this comment.
I think thats a good idea, but it is out of scope for this PR
aegbert5
force-pushed
the
create-state-for-single-run-triggers
branch
2 times, most recently
from
446705d to
c5f711c
Compare
aegbert5
force-pushed
the
create-state-for-single-run-triggers
branch
from
c5f711c to
b6b148f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates the
/triggers/:group/:name/onetime/:idroute to allow for one-time triggers to be created that don't run on a cron schedule. One-time triggers a different from simple triggers, because they require an ID provided to the route, allowing them to be managed outside of piezo