fix: fix that the prop model is not reused and the update is not triggered

liujuping · JackLian · commit 035c213b1681 · 2023-06-01T14:10:16.000+08:00
diff --git a/packages/designer/package.json b/packages/designer/package.json
@@ -15,6 +15,7 @@
   },
   "license": "MIT",
   "dependencies": {
+    "@alilc/build-plugin-lce": "^0.0.4-beta.2",
     "@alilc/lowcode-editor-core": "1.1.7",
     "@alilc/lowcode-types": "1.1.7",
     "@alilc/lowcode-utils": "1.1.7",
diff --git a/packages/designer/src/document/node/props/prop.ts b/packages/designer/src/document/node/props/prop.ts
@@ -148,15 +148,13 @@ export class Prop implements IProp, IPropParent {
 
   @obx.shallow private _items: IProp[] | null = null;
 
-  @obx.shallow private _maps: Map<string | number, IProp> | null = null;
-
   /**
-   * &#20316;&#20026; _maps &#30340;&#19968;&#23618;&#32531;&#23384;&#26426;&#21046;&#65292;&#20027;&#35201;&#26159;&#22797;&#29992;&#37096;&#20998;&#24050;&#23384;&#22312;&#30340; Prop&#65292;&#20445;&#25345;&#21709;&#24212;&#24335;&#20851;&#31995;&#65292;&#27604;&#22914;&#65306;
+   * &#20316;&#20026;&#19968;&#23618;&#32531;&#23384;&#26426;&#21046;&#65292;&#20027;&#35201;&#26159;&#22797;&#29992;&#37096;&#20998;&#24050;&#23384;&#22312;&#30340; Prop&#65292;&#20445;&#25345;&#21709;&#24212;&#24335;&#20851;&#31995;&#65292;&#27604;&#22914;&#65306;
    * &#24403;&#21069; Prop#_value &#20540;&#20026; { a: 1 }&#65292;&#24403;&#35843;&#29992; setValue({ a: 2 }) &#26102;&#65292;&#25152;&#26377;&#21407;&#26469;&#30340;&#23376; Prop &#22343;&#34987;&#38144;&#27585;&#65292;
    * &#23548;&#33268;&#20551;&#22914;&#22806;&#37096;&#26377; mobx reaction&#65288;&#24120;&#35265;&#20110; observer&#65289;&#65292;&#27492;&#26102;&#21709;&#24212;&#24335;&#38142;&#36335;&#20250;&#34987;&#25171;&#26029;&#65292;
    * &#22240;&#20026; reaction &#30417;&#21548;&#30340;&#26159;&#21407; Prop(a) &#30340; _value&#65292;&#32780;&#19981;&#26159;&#26032; Prop(a) &#30340; _value&#12290;
    */
-  private _prevMaps: Map<string | number, IProp> | null = null;
+  @obx.shallow private _maps: Map<string | number, IProp> | null = null;
 
   /**
    * &#26500;&#36896; items &#23646;&#24615;&#65292;&#21516;&#26102;&#26500;&#36896; maps &#23646;&#24615;
@@ -171,8 +169,8 @@ export class Prop implements IProp, IPropParent {
         data.forEach((item: any, idx: number) => {
           items = items || [];
           let prop;
-          if (this._prevMaps?.has(idx.toString())) {
-            prop = this._prevMaps.get(idx.toString())!;
+          if (this._maps?.has(idx.toString())) {
+            prop = this._maps.get(idx.toString())!;
             prop.setValue(item);
           } else {
             prop = new Prop(this, item, idx);
@@ -187,8 +185,8 @@ export class Prop implements IProp, IPropParent {
         const keys = Object.keys(data);
         for (const key of keys) {
           let prop: IProp;
-          if (this._prevMaps?.has(key)) {
-            prop = this._prevMaps.get(key)!;
+          if (this._maps?.has(key)) {
+            prop = this._maps.get(key)!;
             prop.setValue(data[key]);
           } else {
             prop = new Prop(this, data[key], key);
@@ -419,8 +417,6 @@ export class Prop implements IProp, IPropParent {
       items.forEach((prop) => prop.purge());
     }
     this._items = null;
-    this._prevMaps = this._maps;
-    this._maps = null;
     if (this._type !== 'slot' && this._slotNode) {
       this._slotNode.remove();
       this._slotNode = undefined;
diff --git a/packages/designer/tests/document/node/props/prop.test.ts b/packages/designer/tests/document/node/props/prop.test.ts
@@ -379,7 +379,6 @@ describe('Prop &#31867;&#27979;&#35797;', () => {
         prop.dispose();
 
         expect(prop._items).toBeNull();
-        expect(prop._maps).toBeNull();
       });
     });
 
