Now runs jshint on the src/ folder. This fixes the pre-existing lint issues

nfischer · nfischer · commit 900384bda8e6 · 2016-01-19T00:25:21.000-08:00
diff --git a/scripts/run-tests.js b/scripts/run-tests.js
@@ -18,7 +18,7 @@ if (!test('-f', JSHINT_BIN)) {
 
 var jsfiles = common.expand([pwd() + '/*.js',
                              pwd() + '/scripts/*.js',
-                             // pwd() + '/src/*.js',
+                             pwd() + '/src/*.js',
                              pwd() + '/test/*.js'
                             ]).join(' ');
 if (exec('node ' + pwd() + '/' + JSHINT_BIN + ' ' + jsfiles).code !== 0) {
diff --git a/src/chmod.js b/src/chmod.js
@@ -183,12 +183,12 @@ function _chmod(options, mode, filePattern) {
           }
 
           if (options.verbose) {
-            log(file + ' -> ' + newPerms.toString(8));
+            console.log(file + ' -> ' + newPerms.toString(8));
           }
 
           if (perms != newPerms) {
             if (!options.verbose && options.changes) {
-              log(file + ' -> ' + newPerms.toString(8));
+              console.log(file + ' -> ' + newPerms.toString(8));
             }
             fs.chmodSync(file, newPerms);
             perms = newPerms; // for the next round of changes!
diff --git a/src/error.js b/src/error.js
@@ -6,5 +6,5 @@ var common = require('./common');
 //@ otherwise returns string explaining the error
 function error() {
   return common.state.error;
-};
+}
 module.exports = error;
diff --git a/src/exec.js b/src/exec.js
@@ -64,8 +64,10 @@ function execSync(cmd, opts) {
     maxBuffer: 20*1024*1024
   };
 
+  var script;
+
   if (typeof child.execSync === 'function') {
-    var script = [
+    script = [
       "var child = require('child_process')",
       "  , fs = require('fs');",
       "var childProcess = child.exec('"+escape(cmd)+"', {env: process.env, maxBuffer: 20*1024*1024}, function(err) {",
@@ -97,7 +99,7 @@ function execSync(cmd, opts) {
   } else {
     cmd += ' > '+stdoutFile+' 2> '+stderrFile; // works on both win/unix
 
-    var script = [
+    script = [
       "var child = require('child_process')",
       "  , fs = require('fs');",
       "var childProcess = child.exec('"+escape(cmd)+"', {env: process.env, maxBuffer: 20*1024*1024}, function(err) {",
diff --git a/src/pwd.js b/src/pwd.js
@@ -4,7 +4,7 @@ var common = require('./common');
 //@
 //@ ### pwd()
 //@ Returns the current directory.
-function _pwd(options) {
+function _pwd() {
   var pwd = path.resolve(process.cwd());
   return common.ShellString(pwd);
 }
diff --git a/src/rm.js b/src/rm.js
@@ -53,7 +53,7 @@ function rmdirSyncRecursive(dir, force) {
     while (true) {
       try {
         result = fs.rmdirSync(dir);
-        if (fs.existsSync(dir)) throw { code: "EAGAIN" }
+        if (fs.existsSync(dir)) throw { code: "EAGAIN" };
         break;
       } catch(er) {
         // In addition to error codes, also check if the directory still exists and loop again if true
diff --git a/src/which.js b/src/which.js
@@ -14,7 +14,7 @@ function splitPath(p) {
 }
 
 function checkPath(path) {
-  return fs.existsSync(path) && fs.statSync(path).isDirectory() == false;
+  return fs.existsSync(path) && !fs.statSync(path).isDirectory();
 }
 
 //@

Original file line number	Diff line number	Diff line change
`@@ -183,12 +183,12 @@ function _chmod(options, mode, filePattern) {`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`if (options.verbose) {`
`186`		`- log(file + ' -> ' + newPerms.toString(8));`
	`186`	`+ console.log(file + ' -> ' + newPerms.toString(8));`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`if (perms != newPerms) {`
`190`	`190`	`if (!options.verbose && options.changes) {`
`191`		`- log(file + ' -> ' + newPerms.toString(8));`
	`191`	`+ console.log(file + ' -> ' + newPerms.toString(8));`
`192`	`192`	`}`
`193`	`193`	`fs.chmodSync(file, newPerms);`
`194`	`194`	`perms = newPerms; // for the next round of changes!`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ var common = require('./common');`
`4`	`4`	`//@`
`5`	`5`	`//@ ### pwd()`
`6`	`6`	`//@ Returns the current directory.`
`7`		`-function _pwd(options) {`
	`7`	`+function _pwd() {`
`8`	`8`	`var pwd = path.resolve(process.cwd());`
`9`	`9`	`return common.ShellString(pwd);`
`10`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ function splitPath(p) {`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`function checkPath(path) {`
`17`		`- return fs.existsSync(path) && fs.statSync(path).isDirectory() == false;`
	`17`	`+ return fs.existsSync(path) && !fs.statSync(path).isDirectory();`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`//@`