Skip to content

[infra] Use Node 18 for windows-tools test#4333

Merged
augustjk merged 2 commits intomainfrom
windows-ci-node-18
Oct 27, 2023
Merged

[infra] Use Node 18 for windows-tools test#4333
augustjk merged 2 commits intomainfrom
windows-ci-node-18

Conversation

@augustjk
Copy link
Copy Markdown
Member

@augustjk augustjk commented Oct 27, 2023

I've been seeing a lot of windows-tools workflow failures like https://github.com/lit/lit/actions/runs/6660895512/job/18102830296

Possibly related issues:
npm/cli#6763
https://github.com/orgs/nodejs/discussions/49784

There's a potential fix nodejs/node#50136 that hasn't made it to latest node 20 that github actions is getting.

So I'm just trying to downgrade to 18 see if it'll help.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 27, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f6bceba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 27, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +7% (-0.31ms - +1.45ms)
    this-change vs tip-of-tree

render

  • this-change: 76.94ms - 81.14ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +6% (-2.10ms - +1.88ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +3% (-1.56ms - +1.91ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +2% (-2.61ms - +1.15ms)
    this-change vs tip-of-tree

update

  • this-change: 854.49ms - 881.10ms
  • this-change, tip-of-tree, previous-release: slower ❌ 0% - 7% (0.08ms - 4.88ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +3% (-3.75ms - +3.88ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +2% (-25.47ms - +15.28ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 835.95ms - 860.23ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-19.64ms - +15.87ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
76.94ms - 81.14ms-

update

VersionAvg timevs
854.49ms - 881.10ms-

update-reflect

VersionAvg timevs
835.95ms - 860.23ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
31.28ms - 34.26ms-unsure 🔍
-6% - +6%
-2.10ms - +1.88ms		unsure 🔍
-4% - +8%
-1.38ms - +2.44ms
tip-of-tree
tip-of-tree		31.57ms - 34.21msunsure 🔍
-6% - +6%
-1.88ms - +2.10ms		-unsure 🔍
-4% - +8%
-1.13ms - +2.43ms
previous-release
previous-release		31.04ms - 33.44msunsure 🔍
-7% - +4%
-2.44ms - +1.38ms		unsure 🔍
-7% - +3%
-2.43ms - +1.13ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
71.29ms - 75.29ms-slower ❌
0% - 7%
0.08ms - 4.88ms		unsure 🔍
-2% - +5%
-1.56ms - +3.76ms
tip-of-tree
tip-of-tree		69.48ms - 72.14msfaster ✔
0% - 7%
0.08ms - 4.88ms		-unsure 🔍
-5% - +1%
-3.59ms - +0.82ms
previous-release
previous-release		70.43ms - 73.95msunsure 🔍
-5% - +2%
-3.76ms - +1.56ms		unsure 🔍
-1% - +5%
-0.82ms - +3.59ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.82ms - 21.06ms-unsure 🔍
-2% - +7%
-0.31ms - +1.45ms		unsure 🔍
-2% - +7%
-0.48ms - +1.30ms
tip-of-tree
tip-of-tree		19.25ms - 20.50msunsure 🔍
-7% - +1%
-1.45ms - +0.31ms		-unsure 🔍
-5% - +4%
-1.04ms - +0.74ms
previous-release
previous-release		19.39ms - 20.66msunsure 🔍
-6% - +2%
-1.30ms - +0.48ms		unsure 🔍
-4% - +5%
-0.74ms - +1.04ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
56.42ms - 59.35ms-unsure 🔍
-3% - +3%
-1.56ms - +1.91ms		unsure 🔍
-5% - +2%
-2.90ms - +0.90ms
tip-of-tree
tip-of-tree		56.78ms - 58.64msunsure 🔍
-3% - +3%
-1.91ms - +1.56ms		-unsure 🔍
-5% - +1%
-2.70ms - +0.35ms
previous-release
previous-release		57.68ms - 60.10msunsure 🔍
-2% - +5%
-0.90ms - +2.90ms		unsure 🔍
-1% - +5%
-0.35ms - +2.70ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
126.79ms - 132.11ms-unsure 🔍
-3% - +3%
-3.75ms - +3.88ms		unsure 🔍
-3% - +2%
-3.69ms - +2.84ms
tip-of-tree
tip-of-tree		126.66ms - 132.12msunsure 🔍
-3% - +3%
-3.88ms - +3.75ms		-unsure 🔍
-3% - +2%
-3.81ms - +2.83ms
previous-release
previous-release		127.99ms - 131.76msunsure 🔍
-2% - +3%
-2.84ms - +3.69ms		unsure 🔍
-2% - +3%
-2.83ms - +3.81ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
52.06ms - 54.96ms-unsure 🔍
-5% - +2%
-2.61ms - +1.15ms		unsure 🔍
-4% - +2%
-2.20ms - +1.29ms
tip-of-tree
tip-of-tree		53.04ms - 55.44msunsure 🔍
-2% - +5%
-1.15ms - +2.61ms		-unsure 🔍
-2% - +3%
-1.27ms - +1.81ms
previous-release
previous-release		53.00ms - 54.93msunsure 🔍
-2% - +4%
-1.29ms - +2.20ms		unsure 🔍
-3% - +2%
-1.81ms - +1.27ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
861.59ms - 894.23ms-unsure 🔍
-3% - +2%
-25.47ms - +15.28ms		unsure 🔍
-3% - +2%
-22.76ms - +20.08ms
tip-of-tree
tip-of-tree		870.81ms - 895.21msunsure 🔍
-2% - +3%
-15.28ms - +25.47ms		-unsure 🔍
-2% - +3%
-14.72ms - +22.24ms
previous-release
previous-release		865.37ms - 893.13msunsure 🔍
-2% - +3%
-20.08ms - +22.76ms		unsure 🔍
-3% - +2%
-22.24ms - +14.72ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
855.36ms - 879.56ms-unsure 🔍
-2% - +2%
-19.64ms - +15.87ms		unsure 🔍
-3% - +2%
-23.10ms - +14.74ms
tip-of-tree
tip-of-tree		856.35ms - 882.33msunsure 🔍
-2% - +2%
-15.87ms - +19.64ms		-unsure 🔍
-2% - +2%
-21.79ms - +17.20ms
previous-release
previous-release		857.09ms - 886.18msunsure 🔍
-2% - +3%
-14.74ms - +23.10ms		unsure 🔍
-2% - +3%
-17.20ms - +21.79ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 27, 2023

The size of lit-html.js and lit-core.min.js are as expected.

AndrewJakubowicz
AndrewJakubowicz approved these changes Oct 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests did pass! I like it!

@augustjk augustjk enabled auto-merge (squash) October 27, 2023 17:55
@augustjk augustjk merged commit 16257b3 into main Oct 27, 2023
@augustjk augustjk deleted the windows-ci-node-18 branch October 27, 2023 18:28
@CxsLucyfer CxsLucyfer mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@augustjk @AndrewJakubowicz