Add support for HX1200i ATX3.1 variant#763
Conversation
jonasmalacofilho
left a comment
There was a problem hiding this comment.
Hey, thanks for the PR.
The input power curves are unlikely to have remained the same. Please see my other comment.
Regarding the docs, I think having new entries in the README and man page for ATX 3.1 variants can be useful for users, since it's more than just an annual refresh. In the case of the README table, I think a new row just for them should be added.
By the way, do you know whether the 0x1c1e and 0x1c1f variants are ATX 3.1 too?
Finally, the corresponding device guide should receive a "New in ..." note (please see the development process document for details). But a separate device guide is not necessary for the ATX 3.1 variants.
- Learned how to read documentation - Updated Corsair documentation for ATX 3.0 CP-9020281-NA model
Updated efficiency values for HX1200i ATX 3.0
Co-authored-by: Jonas Malaco <[email protected]>
|
LGTM, and thanks for looking into this in this much detail/with this much attention! |
Added and tested addition of HX1200i ATX 3.0 variant PSU.
Fixes: #762
I did not add a new device entry in documentation as the described name in lsusb and marketing material has not changed. If I was incorrect in this decision just point me to how it should be documented and I'm happy to do that work too.
Checklist:
docs/*guide.mddevice guides, with "new/changed in" notesliquidctl.8Linux/Unix/Mac OS man pagedocs/developer/protocolNew CLI flag?
extra/completions/New device?
extra/linux/71-liquidctl.rules(instructions in the file header)gitMRLVNew driver?
docs/developer/protocol/