Support for Corsair iCUE H100i RGB ELITE#557
Merged
jonasmalacofilho merged 8 commits intoliquidctl:mainfrom Jan 14, 2023
st1vms:icue-rgb-elite
Merged
Support for Corsair iCUE H100i RGB ELITE#557jonasmalacofilho merged 8 commits intoliquidctl:mainfrom st1vms:icue-rgb-elite
jonasmalacofilho merged 8 commits intoliquidctl:mainfrom
st1vms:icue-rgb-elite
Conversation
Contributor
Author
|
Would really like some help filling the checklist... |
Member
There was a problem hiding this comment.
Besides the comments on the diff, I'm worried that you might not have fully tested the code you're proposing.
Your code seems to only register the new VID:PID with (what's essentially) the existing HydroPlatinum driver, but this was already attempted before, on a model that we reasonably assume uses the same protocol as your device (H150i ELITE RGB). And, according to #498 (comment), LED control does not seem to work well that way.
Can you also take a look into that?
Another possibility is that you accidentally only committed or pushed part of your changes. This might also explain why you felt it was necessary to duplicate the entire module, while so far the only functional difference between then is registering a new VID:PID pair.
jonasmalacofilho
changed the title
…ry into hydro_platinum
Contributor
Author
|
I probably overcoded this, it was actually much simpler, as adding the All of the funcionalities work properly, from fan duties (using temperature steps) to pump duty and led control. |
This comment was marked as off-topic.
This comment was marked as off-topic.
15 tasks
Member
That's good to hear! But, just to double check (given the problem we saw in the past, that I mentioned above), can you please run and report what happens (visually), as well as post the complete output from the command (including all debug info)? |
Contributor
Author
|
Pump led successfully turned red. |
Co-authored-by: Jonas Malaco <[email protected]>
Member
|
I'll complete the rest of the PR checklist and push directly to your branch (assuming you left that option enabled). |
Member
|
I'll merge this as soon as CI completes (successfully). @st1vms do you which other Elite RGB models exist, and their corresponding PIDs? We know of the H150i ( |
15 tasks
Contributor
Author
|
@jonasmalacofilho Not really, I'd rather stick with an automatic VID:PID Afterall, some of the properties are retrievable just by crawling the product offical page, like number of fans, leds, and so on... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what the changes are meant to address.
If the implementation is not trivial, please also include a short overview.
Fixes:
Closes:
Related:
Checklist:
docs/*guide.mddevice guides, with "new/changed in" notesliquidctl.8Linux/Unix/Mac OS man pagedocs/developer/protocolNew CLI flag?
extra/completions/New device?
extra/linux/71-liquidctl.rules(instructions in the file header)e) andgitMRLVNew driver?
docs/developer/protocol/