Skip to content

feat: added bash completion options for the set lcd screen commands#523

Merged
jonasmalacofilho merged 1 commit intomainfrom
lcd-bash-completion
Oct 14, 2022
Merged

feat: added bash completion options for the set lcd screen commands#523
jonasmalacofilho merged 1 commit intomainfrom
lcd-bash-completion

Conversation

@MarshallAsch
Copy link
Copy Markdown
Member

Describe what the changes are meant to address.

Added the extra sub command options to the bash completion script for the lcd sub commands.

Related: #479


Checklist:

  • Adhere to the development process
  • Conform to the style guide
  • Verify that the changes work as expected on real hardware
  • Add automated tests cases
  • Verify that all (other) automated tests (still) pass
  • Update the README and other applicable documentation pages
  • Update the liquidctl.8 Linux/Unix/Mac OS man page
  • Update or add applicable docs/*guide.md device guides
  • Submit relevant data, scripts or dissectors to https://github.com/liquidctl/collected-device-data

New CLI flag?

  • Adjust the completion scripts in extra/completions/

New device?

  • Regenerate extra/linux/71-liquidctl.rules (instructions in the file header)
  • Add entry to the README's supported device list with applicable notes (at least e) and git MRLV

New driver?

  • Document the protocol in docs/developer/protocol/

Copy link
Copy Markdown
Member

@jonasmalacofilho jonasmalacofilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jonasmalacofilho jonasmalacofilho merged commit 19efd94 into main Oct 14, 2022
@jonasmalacofilho jonasmalacofilho added this to the liquidctl 1.11.0 milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants